Changeset 13904 for trunk/src/bp-core/bp-core-catchuri.php

Timestamp:

06/04/2024 02:32:30 AM (21 months ago)

Author:

espellcaste

Message:

WPCS: Part XI: miscellaneous fixes for some of the files of the core component.

Follow-up to [13903]

See #9164 and #7228

File:

• trunk/src/bp-core/bp-core-catchuri.php (modified) (18 diffs)

trunk/src/bp-core/bp-core-catchuri.php

@@ -46 +46 @@
  * @since 1.6.0
  *
- * @return bool True if yes, false if no.
+ * @return bool
  */
 function bp_core_enable_root_profiles() {
@@ -52 +52 @@
     $retval = false;
 
-    if ( defined( 'BP_ENABLE_ROOT_PROFILES' ) && ( true == BP_ENABLE_ROOT_PROFILES ) )
+    if ( defined( 'BP_ENABLE_ROOT_PROFILES' ) && ( true === BP_ENABLE_ROOT_PROFILES ) ) {
         $retval = true;
+    }
 
     /**
@@ -82 +83 @@
 
     // Reset the post.
-    bp_theme_compat_reset_post( array(
-        'ID'          => 0,
-        'is_404'      => true,
-        'post_status' => 'publish',
-    ) );
+    bp_theme_compat_reset_post(
+        array(
+            'ID'          => 0,
+            'is_404'      => true,
+            'post_status' => 'publish',
+        )
+    );
 
     // Set theme compat to false since the reset post function automatically sets
@@ -118 +121 @@
         }
 
-    // Theme compat doesn't require a template lookup.
+        // Theme compat doesn't require a template lookup.
     } else {
         $template = '';
@@ -185 +188 @@
         exit();
 
-    // No template found, so setup theme compatibility.
-    // @todo Some other 404 handling if theme compat doesn't kick in.
+        // No template found, so setup theme compatibility.
+        // @todo Some other 404 handling if theme compat doesn't kick in.
     } else {
 
@@ -291 +294 @@
     // If coming from bp_core_redirect() and $bp_no_status_set is true,
     // we are redirecting to an accessible page so skip this check.
-    if ( !empty( $bp->no_status_set ) )
+    if ( ! empty( $bp->no_status_set ) ) {
         return false;
-
-    if ( !isset( $wp_query->queried_object ) && !bp_is_blog_page() ) {
+    }
+
+    if ( ! isset( $wp_query->queried_object ) && ! bp_is_blog_page() ) {
         bp_do_404();
     }
@@ -310 +314 @@
  *
  * @param array|string $args {
+ *     Optional. Array of arguments for redirecting user when visiting access controlled areas.
  *     @type int    $mode     Specifies the destination of the redirect. 1 will
  *                            direct to the root domain (home page), which assumes you have a
@@ -332 +337 @@
         'redirect' => $redirect_url,        // the URL you get redirected to when a user successfully logs in.
         'root'     => bp_get_root_url(),    // the landing page you get redirected to when a user doesn't have access.
-        'message'  => __( 'You must log in to access the page you requested.', 'buddypress' )
+        'message'  => __( 'You must log in to access the page you requested.', 'buddypress' ),
     );
 
@@ -348 +353 @@
      */
     $r = apply_filters( 'bp_core_no_access', $r );
+
     extract( $r, EXTR_SKIP );
 
@@ -353 +359 @@
      * @ignore Ignore these filters and use 'bp_core_no_access' above.
      */
-    $mode     = apply_filters( 'bp_no_access_mode',     $mode,     $root,     $redirect, $message );
-    $redirect = apply_filters( 'bp_no_access_redirect', $redirect, $root,     $message,  $mode    );
-    $root     = apply_filters( 'bp_no_access_root',     $root,     $redirect, $message,  $mode    );
-    $message  = apply_filters( 'bp_no_access_message',  $message,  $root,     $redirect, $mode    );
+    $mode     = apply_filters( 'bp_no_access_mode', $mode, $root, $redirect, $message );
+    $redirect = apply_filters( 'bp_no_access_redirect', $redirect, $root, $message, $mode );
+    $root     = apply_filters( 'bp_no_access_root', $root, $redirect, $message, $mode );
+    $message  = apply_filters( 'bp_no_access_message', $message, $root, $redirect, $mode );
     $root     = trailingslashit( $root );
 
@@ -363 +369 @@
         // Option to redirect to wp-login.php.
         // Error message is displayed with bp_core_no_access_wp_login_error().
-        case 2 :
-            if ( !empty( $redirect ) ) {
-                bp_core_redirect( add_query_arg( array(
-                    'bp-auth' => 1,
-                    'action'  => 'bpnoaccess'
-                ), wp_login_url( $redirect ) ) );
+        case 2:
+            if ( ! empty( $redirect ) ) {
+                bp_core_redirect(
+                    add_query_arg(
+                        array(
+                            'bp-auth' => 1,
+                            'action'  => 'bpnoaccess',
+                        ),
+                        wp_login_url( $redirect )
+                    )
+                );
             } else {
                 bp_core_redirect( $root );
@@ -377 +388 @@
         // Redirect to root with "redirect_to" parameter.
         // Error message is displayed with bp_core_add_message().
-        case 1 :
-        default :
-
+        case 1:
+        default:
             $url = $root;
-            if ( !empty( $redirect ) ) {
+            if ( ! empty( $redirect ) ) {
                 $url = add_query_arg( 'redirect_to', urlencode( $redirect ), $root );
             }
 
-            if ( !empty( $message ) ) {
+            if ( ! empty( $message ) ) {
                 bp_core_add_message( $message, 'error' );
             }
@@ -502 +512 @@
 
         // Build the URL in the address bar.
-        $requested_url  = bp_get_requested_url();
-        $query_args     = '';
+        $requested_url = bp_get_requested_url();
+        $query_args    = '';
 
         // Stash query args.
@@ -582 +592 @@
     // is set to be the front page, ensure that the current canonical URL
     // is the home page URL.
-    if ( 'page' == get_option( 'show_on_front' ) && $page_on_front = (int) get_option( 'page_on_front' ) ) {
-        $front_page_component = array_search( $page_on_front, bp_core_get_directory_page_ids() );
+    if ( 'page' === get_option( 'show_on_front' ) && $page_on_front = (int) get_option( 'page_on_front' ) ) {
+        $front_page_component = array_search( $page_on_front, bp_core_get_directory_page_ids(), true );
 
         /*
@@ -595 +605 @@
             $bp->canonical_stack['canonical_url'] = trailingslashit( bp_get_root_url() );
 
-        // Except when the front page is set to the registration page
-        // and the current user is logged in. In this case we send to
-        // the members directory to avoid redirect loops.
-        } elseif ( bp_is_register_page() && 'register' == $front_page_component && is_user_logged_in() ) {
+            // Except when the front page is set to the registration page
+            // and the current user is logged in. In this case we send to
+            // the members directory to avoid redirect loops.
+        } elseif ( bp_is_register_page() && 'register' === $front_page_component && is_user_logged_in() ) {
 
             /**
@@ -613 +623 @@
     if ( empty( $bp->canonical_stack['canonical_url'] ) ) {
         // Build the URL in the address bar.
-        $requested_url  = bp_get_requested_url();
-        $base_url       = '';
-        $path_chunks    = array();
-        $component_id   = '';
+        $requested_url = bp_get_requested_url();
+        $base_url      = '';
+        $path_chunks   = array();
+        $component_id  = '';
 
         // Get query args.
@@ -678 +688 @@
         } elseif ( isset( $query_args['bp_member_action'] ) && 'members' === $component_id ) {
             unset( $query_args['bp_member_action'] );
-        } elseif( isset( $query_args['bp_group_action'] ) && 'groups' === $component_id ) {
+        } elseif ( isset( $query_args['bp_group_action'] ) && 'groups' === $component_id ) {
             unset( $query_args['bp_group_action'] );
         }
@@ -750 +760 @@
  */
 function _bp_maybe_remove_redirect_canonical() {
-    if ( ! bp_is_blog_page() )
+    if ( ! bp_is_blog_page() ) {
         remove_action( 'template_redirect', 'redirect_canonical' );
+    }
 }