Changeset 13903 for trunk/src/bp-core/bp-core-theme-compatibility.php

Timestamp:

06/04/2024 02:30:49 AM (2 years ago)

Author:

espellcaste

Message:

WPCS: Part X: miscellaneous fixes for some of the files of the core component.

Follow-up to [13901]

See #9164 and #7228

File:

• trunk/src/bp-core/bp-core-theme-compatibility.php (modified) (9 diffs)

trunk/src/bp-core/bp-core-theme-compatibility.php

@@ -36 +36 @@
 
         // Make sure theme package is available, set to default if not.
-        if ( ! isset( $bp->theme_compat->packages[$theme] ) || ! is_a( $bp->theme_compat->packages[$theme], 'BP_Theme_Compat' ) ) {
+        if ( ! isset( $bp->theme_compat->packages[ $theme ] ) || ! is_a( $bp->theme_compat->packages[ $theme ], 'BP_Theme_Compat' ) ) {
                 $theme = 'legacy';
         }
 
         // Set the active theme compat theme.
-        $bp->theme_compat->theme = $bp->theme_compat->packages[$theme];
+        $bp->theme_compat->theme = $bp->theme_compat->packages[ $theme ];
 }
 
@@ -208 +208 @@
                 $theme_compat = false;
 
-        // If the theme doesn't support BP, do some additional checks.
-        } else {
+                // If the theme doesn't support BP, do some additional checks.
+        } elseif ( in_array( 'bp-default', array( get_template(), get_stylesheet() ), true ) ) {
                 // Bail if theme is a derivative of bp-default.
-                if ( in_array( 'bp-default', array( get_template(), get_stylesheet() ) ) ) {
-                        $theme_compat = false;
+                $theme_compat = false;
 
                 // Brute-force check for a BP template.
                 // Examples are clones of bp-default.
-                } elseif ( locate_template( 'members/members-loop.php', false, false ) ) {
-                        $theme_compat = false;
-                }
+        } elseif ( locate_template( 'members/members-loop.php', false, false ) ) {
+                $theme_compat = false;
         }
 
@@ -250 +248 @@
  *
  * @param bool $set True to set the flag to true, false to set it to false.
- * @return bool Returns the value of $set.
+ * @return bool
  */
 function bp_set_theme_compat_active( $set = true ) {
@@ -462 +460 @@
         }
 
-        bp_set_theme_compat_feature( 'legacy', array(
-                'name'     => 'cover_image',
-                'settings' => array(
-                        'components'   => array( 'members', 'groups' ),
-                        'width'        => $bp_content_width,
-                        'height'       => $top_offset + round( $avatar_height / 2 ),
-                        'callback'     => 'bp_legacy_theme_cover_image',
-                        'theme_handle' => $bp_handle,
-                ),
-        ) );
+        bp_set_theme_compat_feature(
+                'legacy',
+                array(
+                        'name'     => 'cover_image',
+                        'settings' => array(
+                                'components'   => array( 'members', 'groups' ),
+                                'width'        => $bp_content_width,
+                                'height'       => $top_offset + round( $avatar_height / 2 ),
+                                'callback'     => 'bp_legacy_theme_cover_image',
+                                'theme_handle' => $bp_handle,
+                        ),
+                )
+        );
 }
 
@@ -490 +491 @@
         }
 
-        return (bool) ( $bp->theme_compat->original_template == $template );
+        return (bool) ( $bp->theme_compat->original_template === $template );
 }
 
@@ -524 +525 @@
         // Only set if the theme package was not previously registered or if the
         // override flag is set.
-        if ( empty( $bp->theme_compat->packages[$theme->id] ) || ( true === $override ) ) {
-                $bp->theme_compat->packages[$theme->id] = $theme;
+        if ( empty( $bp->theme_compat->packages[ $theme->id ] ) || ( true === $override ) ) {
+                $bp->theme_compat->packages[ $theme->id ] = $theme;
         }
 }
@@ -632 +633 @@
 
         // Copy the new post global into the main $wp_query.
-        $wp_query->post       = $post;
-        $wp_query->posts      = array( $post );
+        $wp_query->post  = $post;
+        $wp_query->posts = array( $post );
 
         // Prevent comments form from appearing.
@@ -821 +822 @@
 
         // Filters exist.
-        if ( isset( $wp_filter[$tag] ) ) {
+        if ( isset( $wp_filter[ $tag ] ) ) {
 
                 // Filters exist in this priority.
-                if ( ! empty( $priority ) && isset( $wp_filter[$tag][$priority] ) ) {
+                if ( ! empty( $priority ) && isset( $wp_filter[ $tag ][ $priority ] ) ) {
 
                         // Store filters in a backup.
-                        $bp->filters->wp_filter[$tag][$priority] = $wp_filter[$tag][$priority];
+                        $bp->filters->wp_filter[ $tag ][ $priority ] = $wp_filter[ $tag ][ $priority ];
 
                         // Unset the filters.
-                        unset( $wp_filter[$tag][$priority] );
-
-                // Priority is empty.
+                        unset( $wp_filter[ $tag ][ $priority ] );
+
+                        // Priority is empty.
                 } else {
 
                         // Store filters in a backup.
-                        $bp->filters->wp_filter[$tag] = $wp_filter[$tag];
+                        $bp->filters->wp_filter[ $tag ] = $wp_filter[ $tag ];
 
                         // Unset the filters.
-                        unset( $wp_filter[$tag] );
+                        unset( $wp_filter[ $tag ] );
                 }
         }
 
         // Check merged filters.
-        if ( isset( $merged_filters[$tag] ) ) {
+        if ( isset( $merged_filters[ $tag ] ) ) {
 
                 // Store filters in a backup.
-                $bp->filters->merged_filters[$tag] = $merged_filters[$tag];
+                $bp->filters->merged_filters[ $tag ] = $merged_filters[ $tag ];
 
                 // Unset the filters.
-                unset( $merged_filters[$tag] );
+                unset( $merged_filters[ $tag ] );
         }
 
@@ -876 +877 @@
 
         // Filters exist.
-        if ( isset( $bp->filters->wp_filter[$tag] ) ) {
+        if ( isset( $bp->filters->wp_filter[ $tag ] ) ) {
 
                 // Filters exist in this priority.
-                if ( ! empty( $priority ) && isset( $bp->filters->wp_filter[$tag][$priority] ) ) {
+                if ( ! empty( $priority ) && isset( $bp->filters->wp_filter[ $tag ][ $priority ] ) ) {
 
                         // Store filters in a backup.
-                        $wp_filter[$tag][$priority] = $bp->filters->wp_filter[$tag][$priority];
+                        $wp_filter[ $tag ][ $priority ] = $bp->filters->wp_filter[ $tag ][ $priority ];
 
                         // Unset the filters.
-                        unset( $bp->filters->wp_filter[$tag][$priority] );
-
-                // Priority is empty.
+                        unset( $bp->filters->wp_filter[ $tag ][ $priority ] );
+
+                        // Priority is empty.
                 } else {
 
                         // Store filters in a backup.
-                        $wp_filter[$tag] = $bp->filters->wp_filter[$tag];
+                        $wp_filter[ $tag ] = $bp->filters->wp_filter[ $tag ];
 
                         // Unset the filters.
-                        unset( $bp->filters->wp_filter[$tag] );
+                        unset( $bp->filters->wp_filter[ $tag ] );
                 }
         }
 
         // Check merged filters.
-        if ( isset( $bp->filters->merged_filters[$tag] ) ) {
+        if ( isset( $bp->filters->merged_filters[ $tag ] ) ) {
 
                 // Store filters in a backup.
-                $merged_filters[$tag] = $bp->filters->merged_filters[$tag];
+                $merged_filters[ $tag ] = $bp->filters->merged_filters[ $tag ];
 
                 // Unset the filters.
-                unset( $bp->filters->merged_filters[$tag] );
+                unset( $bp->filters->merged_filters[ $tag ] );
         }