Changeset 13903 for trunk/src/bp-core/bp-core-moderation.php

Timestamp:

06/04/2024 02:30:49 AM (20 months ago)

Author:

espellcaste

Message:

WPCS: Part X: miscellaneous fixes for some of the files of the core component.

Follow-up to [13901]

See #9164 and #7228

File:

• trunk/src/bp-core/bp-core-moderation.php (modified) (7 diffs)

trunk/src/bp-core/bp-core-moderation.php

@@ -26 +26 @@
 function bp_core_check_for_flood( $user_id = 0 ) {
 
+    $throttle_time = bp_get_option( '_bp_throttle_time' );
+
     // Option disabled. No flood checks.
-    if ( !$throttle_time = bp_get_option( '_bp_throttle_time' ) ) {
+    if ( ! $throttle_time ) {
         return true;
     }
@@ -37 +39 @@
 
     $last_posted = get_user_meta( $user_id, '_bp_last_posted', true );
-    if ( isset( $last_posted ) && ( time() < ( $last_posted + $throttle_time ) ) && !current_user_can( 'throttle' ) ) {
+    if ( isset( $last_posted ) && ( time() < ( $last_posted + $throttle_time ) ) && ! current_user_can( 'throttle' ) ) {
         return false;
     }
@@ -79 +81 @@
     // Define local variable(s).
     $_post   = array();
-    $matches = '';
+    $matches = array();
 
     /** User Data ************************************************************
@@ -119 +121 @@
             foreach ( $matches[0] as $found_url ) {
                 if ( 0 === strpos( $found_url, home_url() ) ) {
-                    $num_links -=1;
+                    --$num_links;
                 }
             }
@@ -298 +300 @@
 
         // Skip empty lines.
-        if ( empty( $word ) ) { continue; }
+        if ( empty( $word ) ) {
+            continue;
+        }
 
         // Do some escaping magic so that '#' chars in the
@@ -332 +336 @@
 function bp_core_current_user_ip() {
     $retval = '';
+
     if ( isset( $_SERVER['REMOTE_ADDR'] ) ) {
         $retval = preg_replace( '/[^0-9a-fA-F:., ]/', '', wp_unslash( $_SERVER['REMOTE_ADDR'] ) );
@@ -354 +359 @@
  */
 function bp_core_current_user_ua() {
+    $retval = '';
 
     // Sanity check the user agent.
     if ( ! empty( $_SERVER['HTTP_USER_AGENT'] ) ) {
         $retval = substr( $_SERVER['HTTP_USER_AGENT'], 0, 254 );
-    } else {
-        $retval = '';
     }