Changeset 13901 for trunk/src/bp-core/classes/class-bp-button.php

Timestamp:

06/02/2024 07:14:55 PM (20 months ago)

Author:

espellcaste

Message:

WPCS: Part IX: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], [13888], [13891], [13892], [13893] and [13900]

See #9164 and #7228

File:

• trunk/src/bp-core/classes/class-bp-button.php (modified) (11 diffs)

trunk/src/bp-core/classes/class-bp-button.php

@@ -233 +233 @@
      * @since 1.2.6
      *
-     * @param array|string $args See {@BP_Button}.
+     * @param array|string $args See `BP_Button`.
      */
     public function __construct( $args = '' ) {
@@ -246 +246 @@
 
         // Deprecated. Subject to removal in a future release.
+
         $this->wrapper = $r['wrapper'];
-        if ( !empty( $r['link_id']    ) ) $this->link_id    = ' id="' .    $r['link_id']    . '"';
-        if ( !empty( $r['link_href']  ) ) $this->link_href  = ' href="' .  $r['link_href']  . '"';
-        if ( !empty( $r['link_title'] ) ) $this->link_title = ' title="' . $r['link_title'] . '"';
-        if ( !empty( $r['link_rel']   ) ) $this->link_rel   = ' rel="' .   $r['link_rel']   . '"';
-        if ( !empty( $r['link_class'] ) ) $this->link_class = ' class="' . $r['link_class'] . '"';
-        if ( !empty( $r['link_text']  ) ) $this->link_text  =              $r['link_text'];
+
+        if ( ! empty( $r['link_id'] ) ) {
+            $this->link_id = ' id="' . $r['link_id'] . '"';
+        }
+        if ( ! empty( $r['link_href'] ) ) {
+            $this->link_href = ' href="' . $r['link_href'] . '"';
+        }
+        if ( ! empty( $r['link_title'] ) ) {
+            $this->link_title = ' title="' . $r['link_title'] . '"';
+        }
+        if ( ! empty( $r['link_rel'] ) ) {
+            $this->link_rel = ' rel="' . $r['link_rel'] . '"';
+        }
+        if ( ! empty( $r['link_class'] ) ) {
+            $this->link_class = ' class="' . $r['link_class'] . '"';
+        }
+        if ( ! empty( $r['link_text'] ) ) {
+            $this->link_text = $r['link_text'];
+        }
 
         // Required button properties.
@@ -262 +276 @@
         // $id and $component are required and component must be active.
         if ( empty( $r['id'] ) || empty( $r['component'] ) || ! bp_is_active( $this->component ) ) {
-            return false;
+            return;
         }
 
         // No button for guests if must be logged in.
-        if ( true == $this->must_be_logged_in && ! is_user_logged_in() ) {
-            return false;
+        if ( true === $this->must_be_logged_in && ! is_user_logged_in() ) {
+            return;
         }
 
         // The block_self property.
-        if ( true == $this->block_self ) {
+        if ( true === $this->block_self ) {
             /*
              * No button if you are the current user in a members loop.
@@ -279 +293 @@
              */
             if ( bp_get_member_user_id() ) {
-                if ( is_user_logged_in() && bp_loggedin_user_id() == bp_get_member_user_id() ) {
-                    return false;
+                if ( is_user_logged_in() && bp_loggedin_user_id() === bp_get_member_user_id() ) {
+                    return;
                 }
 
-            // No button if viewing your own profile (and not in a members loop).
+                // No button if viewing your own profile (and not in a members loop).
             } elseif ( bp_is_my_profile() ) {
-                return false;
+                return;
             }
         }
@@ -311 +325 @@
 
             // Render parent element attributes.
-            $parent_elem = new BP_Core_HTML_Element( array(
-                'element' => $r['parent_element'],
-                'attr'    => $r['parent_attr']
-            ) );
+            $parent_elem = new BP_Core_HTML_Element(
+                array(
+                    'element' => $r['parent_element'],
+                    'attr'    => $r['parent_attr'],
+                )
+            );
 
             // Set before and after.
@@ -320 +336 @@
             $after  = $parent_elem->get( 'close_tag' );
 
-        // No parent element.
+            // No parent element.
         } else {
-            $before = $after = '';
+            $before = '';
+            $after  = '';
         }
 
@@ -339 +356 @@
             }
 
-            $button = new BP_Core_HTML_Element( array(
-                'element'    => $r['button_element'],
-                'attr'       => $r['button_attr'],
-                'inner_html' => ! empty( $r['link_text'] ) ? $r['link_text'] : ''
-            ) );
+            $button = new BP_Core_HTML_Element(
+                array(
+                    'element'    => $r['button_element'],
+                    'attr'       => $r['button_attr'],
+                    'inner_html' => ! empty( $r['link_text'] ) ? $r['link_text'] : '',
+                )
+            );
             $button = $button->contents();
         }
@@ -374 +393 @@
      * @since 2.7.0.
      *
-     * @param  array $r See {@link BP_Button} class for full documentation.
+     * @param  array $r See {@see BP_Button} class for full documentation.
      * @return array
      */
@@ -380 +399 @@
         // Array of deprecated arguments.
         $backpat_args = array(
-            'wrapper', 'wrapper_class', 'wrapper_id',
-            'link_href', 'link_class', 'link_id', 'link_rel', 'link_title'
+            'wrapper',
+            'wrapper_class',
+            'wrapper_id',
+            'link_href',
+            'link_class',
+            'link_id',
+            'link_rel',
+            'link_title',
         );
 
@@ -389 +414 @@
             }
 
-            $parent = $child = false;
+            $parent = false;
+            $child  = false;
             $sep    = strpos( $prop, '_' );
 
@@ -410 +436 @@
                 $r[ "{$parent}_element" ] = $r[ $prop ];
 
-            // Set attributes.
+                // Set attributes.
             } elseif ( true === $child ) {
-                $new_prop = substr( $prop, strpos( $prop, '_' ) +1 );
+                $new_prop = substr( $prop, strpos( $prop, '_' ) + 1 );
                 if ( empty( $r[ "{$parent}_attr" ] ) ) {
                     $r[ "{$parent}_attr" ] = array();