Changeset 13862

Timestamp:

05/11/2024 10:19:04 AM (7 months ago)

Author:

imath

Message:

BP Nouveau: use the right user ID to accept a group invite

The displayed user ID should only be used when an administrator is viewing a user profile. In all other contexts, the logged in user ID needs to be used. This change is fixing the issue when accepting such an invite from the groups directory.

Props kainelabsteam, dcavins

Fixes #9135
Closes ​https://github.com/buddypress/buddypress/pull/285

File:

• trunk/src/bp-templates/bp-nouveau/includes/groups/ajax.php (modified) (7 diffs)

trunk/src/bp-templates/bp-nouveau/includes/groups/ajax.php

@@ -4 +4 @@
  *
  * @since 3.0.0
- * @version 12.0.0
+ * @version 14.0.0
  */
 
@@ -75 +75 @@
     // Cast gid as integer.
     $group_id = (int) $_POST['item_id'];
+    $user_id  = bp_loggedin_user_id();
+
+    if ( bp_is_user_groups() && bp_current_user_can_moderate() ) {
+        $user_id = bp_displayed_user_id();
+    }
 
     $errors = array(
@@ -81 +86 @@
     );
 
-    if ( groups_is_user_banned( bp_loggedin_user_id(), $group_id ) ) {
+    if ( groups_is_user_banned( $user_id, $group_id ) ) {
         $response['feedback'] = $errors['cannot'];
 
@@ -98 +103 @@
 
         case 'groups_accept_invite':
-            if ( ! groups_check_user_has_invite( bp_displayed_user_id(), $group_id ) ) {
+            if ( ! groups_check_user_has_invite( $user_id, $group_id ) ) {
                 wp_send_json_error( $response );
             }
 
-            if ( ! groups_accept_invite( bp_displayed_user_id(), $group_id ) ) {
+            if ( ! groups_accept_invite( $user_id, $group_id ) ) {
                 $response = array(
                     'feedback' => sprintf(
@@ -138 +143 @@
 
         case 'groups_reject_invite':
-            if ( ! groups_reject_invite( bp_displayed_user_id(), $group_id ) ) {
+            if ( ! groups_reject_invite( $user_id, $group_id ) ) {
                 $response = array(
                     'feedback' => sprintf(
@@ -159 +164 @@
 
         case 'groups_join_group':
-            if ( groups_is_user_member( bp_loggedin_user_id(), $group->id ) ) {
+            if ( groups_is_user_member( $user_id, $group->id ) ) {
                 $response = array(
                     'feedback' => $errors['member'],
@@ -190 +195 @@
 
             case 'groups_request_membership' :
-                if ( ! groups_send_membership_request( [ 'user_id' => bp_loggedin_user_id(), 'group_id' => $group->id ] ) ) {
+                if ( ! groups_send_membership_request( [ 'user_id' => $user_id, 'group_id' => $group->id ] ) ) {
                     $response = array(
                         'feedback' => sprintf(