Changeset 13814

Timestamp:

04/27/2024 09:56:51 AM (22 months ago)

Author:

imath

Message:

Settings component: improve PHP code standards using WPCS

See #7228 (trunk)

Location:

trunk/src/bp-settings

Files:

• bp-settings-functions.php (modified) (1 diff)
• bp-settings-template.php (modified) (4 diffs)

trunk/src/bp-settings/bp-settings-functions.php

@@ -361 +361 @@
          * @param string $exporter      Internal exporter name.
          */
-        $item = apply_filters( 'bp_settings_data_exporter_name', esc_html( $friendly_name ), $exporter );
+        $item = apply_filters( 'bp_settings_data_exporter_name', $friendly_name, $exporter );
     ?>
 
-        <li><?php echo $item; ?></li>
+        <li><?php echo esc_html( $item ); ?></li>
 
     <?php endforeach; ?>

trunk/src/bp-settings/bp-settings-template.php

@@ -17 +17 @@
  */
 function bp_settings_slug() {
-    echo bp_get_settings_slug();
+    echo esc_url( bp_get_settings_slug() );
 }
 
@@ -45 +45 @@
  */
 function bp_settings_root_slug() {
-    echo bp_get_settings_root_slug();
+    echo esc_url( bp_get_settings_root_slug() );
 }
 
@@ -100 +100 @@
             printf(
                 /* translators: %s: new email address */
-                __( 'There is a pending change of your email address to %s.', 'buddypress' ),
+                esc_html__( 'There is a pending change of your email address to %s.', 'buddypress' ),
                 '<code>' . esc_html( $pending_email['newemail'] ) . '</code>'
             );
@@ -108 +108 @@
             printf(
                 /* translators: 1: email address. 2: cancel email change url. */
-                __( 'Check your email (%1$s) for the verification link, or <a href="%2$s">cancel the pending change</a>.', 'buddypress' ),
+                esc_html__( 'Check your email (%1$s) for the verification link, or %2$s.', 'buddypress' ),
                 '<code>' . esc_html( $pending_email['newemail'] ) . '</code>',
-                esc_url( $dismiss_url )
+                '<a href="' . esc_url( $dismiss_url ) . '">' . esc_html__( 'cancel the pending change', 'buddypress' ) . '</a>'
             );
             ?>