Changeset 13808 for trunk/src/bp-groups/bp-groups-notifications.php

Timestamp:

04/26/2024 05:44:26 AM (2 years ago)

Author:

imath

Message:

Groups component: improve PHP code standards using WPCS

See #7228 (trunk)

File:

• trunk/src/bp-groups/bp-groups-notifications.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-notifications.php

@@ -1161 +1161 @@
 function groups_screen_notification_settings() {
 
-        if ( !$group_invite = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_invite', true ) )
+        if ( ! $group_invite = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_invite', true ) ) {
                 $group_invite  = 'yes';
-
-        if ( !$group_update = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_group_updated', true ) )
+        }
+
+        if ( ! $group_update = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_group_updated', true ) ) {
                 $group_update  = 'yes';
-
-        if ( !$group_promo = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_admin_promotion', true ) )
+        }
+
+        if ( ! $group_promo = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_admin_promotion', true ) ) {
                 $group_promo   = 'yes';
-
-        if ( !$group_request = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_membership_request', true ) )
+        }
+
+        if ( ! $group_request = bp_get_user_meta( bp_displayed_user_id(), 'notification_groups_membership_request', true ) ) {
                 $group_request = 'yes';
+        }
 
         if ( ! $group_request_completed = bp_get_user_meta( bp_displayed_user_id(), 'notification_membership_request_completed', true ) ) {
@@ -1182 +1186 @@
                         <tr>
                                 <th class="icon"></th>
-                                <th class="title"><?php _ex( 'Groups', 'Group settings on notification settings page', 'buddypress' ) ?></th>
-                                <th class="yes"><?php _e( 'Yes', 'buddypress' ) ?></th>
-                                <th class="no"><?php _e( 'No', 'buddypress' )?></th>
+                                <th class="title"><?php echo esc_html_x( 'Groups', 'Group settings on notification settings page', 'buddypress' ) ?></th>
+                                <th class="yes"><?php esc_html_e( 'Yes', 'buddypress' ) ?></th>
+                                <th class="no"><?php esc_html_e( 'No', 'buddypress' )?></th>
                         </tr>
                 </thead>
@@ -1191 +1195 @@
                         <tr id="groups-notification-settings-invitation">
                                 <td></td>
-                                <td><?php _ex( 'A member invites you to join a group', 'group settings on notification settings page','buddypress' ) ?></td>
+                                <td><?php echo esc_html_x( 'A member invites you to join a group', 'group settings on notification settings page','buddypress' ) ?></td>
                                 <td class="yes"><input type="radio" name="notifications[notification_groups_invite]" id="notification-groups-invite-yes" value="yes" <?php checked( $group_invite, 'yes', true ) ?>/><label for="notification-groups-invite-yes" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'Yes, send email', 'buddypress' );
+                                        esc_html_e( 'Yes, send email', 'buddypress' );
                                 ?></label></td>
                                 <td class="no"><input type="radio" name="notifications[notification_groups_invite]" id="notification-groups-invite-no" value="no" <?php checked( $group_invite, 'no', true ) ?>/><label for="notification-groups-invite-no" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'No, do not send email', 'buddypress' );
+                                        esc_html_e( 'No, do not send email', 'buddypress' );
                                 ?></label></td>
                         </tr>
                         <tr id="groups-notification-settings-info-updated">
                                 <td></td>
-                                <td><?php _ex( 'Group information is updated', 'group settings on notification settings page', 'buddypress' ) ?></td>
+                                <td><?php echo esc_html_x( 'Group information is updated', 'group settings on notification settings page', 'buddypress' ) ?></td>
                                 <td class="yes"><input type="radio" name="notifications[notification_groups_group_updated]" id="notification-groups-group-updated-yes" value="yes" <?php checked( $group_update, 'yes', true ) ?>/><label for="notification-groups-group-updated-yes" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'Yes, send email', 'buddypress' );
+                                        esc_html_e( 'Yes, send email', 'buddypress' );
                                 ?></label></td>
                                 <td class="no"><input type="radio" name="notifications[notification_groups_group_updated]" id="notification-groups-group-updated-no" value="no" <?php checked( $group_update, 'no', true ) ?>/><label for="notification-groups-group-updated-no" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'No, do not send email', 'buddypress' );
+                                        esc_html_e( 'No, do not send email', 'buddypress' );
                                 ?></label></td>
                         </tr>
                         <tr id="groups-notification-settings-promoted">
                                 <td></td>
-                                <td><?php _ex( 'You are promoted to a group administrator or moderator', 'group settings on notification settings page', 'buddypress' ) ?></td>
+                                <td><?php echo esc_html_x( 'You are promoted to a group administrator or moderator', 'group settings on notification settings page', 'buddypress' ) ?></td>
                                 <td class="yes"><input type="radio" name="notifications[notification_groups_admin_promotion]" id="notification-groups-admin-promotion-yes" value="yes" <?php checked( $group_promo, 'yes', true ) ?>/><label for="notification-groups-admin-promotion-yes" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'Yes, send email', 'buddypress' );
+                                        esc_html_e( 'Yes, send email', 'buddypress' );
                                 ?></label></td>
                                 <td class="no"><input type="radio" name="notifications[notification_groups_admin_promotion]" id="notification-groups-admin-promotion-no" value="no" <?php checked( $group_promo, 'no', true ) ?>/><label for="notification-groups-admin-promotion-no" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'No, do not send email', 'buddypress' );
+                                        esc_html_e( 'No, do not send email', 'buddypress' );
                                 ?></label></td>
                         </tr>
                         <tr id="groups-notification-settings-request">
                                 <td></td>
-                                <td><?php _ex( 'A member requests to join a private group for which you are an admin', 'group settings on notification settings page', 'buddypress' ) ?></td>
+                                <td><?php echo esc_html_x( 'A member requests to join a private group for which you are an admin', 'group settings on notification settings page', 'buddypress' ) ?></td>
                                 <td class="yes"><input type="radio" name="notifications[notification_groups_membership_request]" id="notification-groups-membership-request-yes" value="yes" <?php checked( $group_request, 'yes', true ) ?>/><label for="notification-groups-membership-request-yes" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'Yes, send email', 'buddypress' );
+                                        esc_html_e( 'Yes, send email', 'buddypress' );
                                 ?></label></td>
                                 <td class="no"><input type="radio" name="notifications[notification_groups_membership_request]" id="notification-groups-membership-request-no" value="no" <?php checked( $group_request, 'no', true ) ?>/><label for="notification-groups-membership-request-no" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'No, do not send email', 'buddypress' );
+                                        esc_html_e( 'No, do not send email', 'buddypress' );
                                 ?></label></td>
                         </tr>
                         <tr id="groups-notification-settings-request-completed">
                                 <td></td>
-                                <td><?php _ex( 'Your request to join a group has been approved or denied', 'group settings on notification settings page', 'buddypress' ) ?></td>
+                                <td><?php echo esc_html_x( 'Your request to join a group has been approved or denied', 'group settings on notification settings page', 'buddypress' ) ?></td>
                                 <td class="yes"><input type="radio" name="notifications[notification_membership_request_completed]" id="notification-groups-membership-request-completed-yes" value="yes" <?php checked( $group_request_completed, 'yes', true ) ?>/><label for="notification-groups-membership-request-completed-yes" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'Yes, send email', 'buddypress' );
+                                        esc_html_e( 'Yes, send email', 'buddypress' );
                                 ?></label></td>
                                 <td class="no"><input type="radio" name="notifications[notification_membership_request_completed]" id="notification-groups-membership-request-completed-no" value="no" <?php checked( $group_request_completed, 'no', true ) ?>/><label for="notification-groups-membership-request-completed-no" class="bp-screen-reader-text"><?php
                                         /* translators: accessibility text */
-                                        _e( 'No, do not send email', 'buddypress' );
+                                        esc_html_e( 'No, do not send email', 'buddypress' );
                                 ?></label></td>
                         </tr>