Changeset 13797 for trunk/tests/phpunit/testcases/xprofile/template.php

Timestamp:

04/20/2024 06:48:57 PM (2 years ago)

Author:

espellcaste

Message:

While pulling XProfile group fields objects from cache with the BP_XProfile_Group::get method,
avoid unnecessary queries for the cached bp_xprofile_get_signup_field_ids() function.

See #8976

File:

• trunk/tests/phpunit/testcases/xprofile/template.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/xprofile/template.php

@@ -94 +94 @@
             array(
                 'field_group_id' => $group_1,
-                'type' => 'textbox',
-                'name' => 'InSignupForm1'
+                'type'           => 'textbox',
+                'name'           => 'InSignupForm1'
             )
         );
@@ -105 +105 @@
             array(
                 'field_group_id' => $group_2,
-                'type' => 'textbox',
-                'name' => 'InSignupForm2'
+                'type'           => 'textbox',
+                'name'           => 'InSignupForm2'
             )
         );
@@ -121 +121 @@
         $this->assertSame( $expected_names, $names );
 
+        // Confirm the fields are in the right order.
+        $this->assertSame( 'InSignupForm2', $group->fields[1]->name );
+        $this->assertSame( 'InSignupForm1', $group->fields[2]->name );
+
         xprofile_delete_field_group( $group_1 );
         xprofile_delete_field_group( $group_2 );
@@ -139 +143 @@
         $g3 = self::factory()->xprofile_group->create();
 
-        $field_in_1 = self::factory()->xprofile_field->create(
+        self::factory()->xprofile_field->create(
             [
                 'field_group_id' => $g1,
@@ -147 +151 @@
         );
 
-        $field_in_2 = self::factory()->xprofile_field->create(
+        self::factory()->xprofile_field->create(
             [
                 'field_group_id' => $g2,