Changeset 13792 for trunk/tests/phpunit/testcases/xprofile/functions.php

Timestamp:

04/12/2024 01:12:04 PM (2 years ago)

Author:

espellcaste

Message:

A BP_XProfile_Field update does not disassociate from its XProfile parent field.

This patch makes sure that when updating an existing XProfile field option using the save() method from the BP_XProfile_Field class,
the updated option has not the parent_id set to 0, thus becoming disassociated from its XProfile parent field.

Closes ​https://github.com/buddypress/buddypress/pull/267
Fixes #9130

File:

• trunk/tests/phpunit/testcases/xprofile/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/xprofile/functions.php

@@ -699 +699 @@
 
     /**
+     * @ticket BP9130
+     */
+    public function test_xprofile_update_keep_parent_id() {
+        $g      = self::factory()->xprofile_group->create();
+        $parent = self::factory()->xprofile_field->create( array(
+            'field_group_id' => $g,
+            'type'           => 'selectbox',
+            'name'           => 'Parent',
+        ) );
+
+        $f = xprofile_insert_field(
+            array(
+                'field_group_id' => $g,
+                'parent_id'      => $parent,
+                'type'           => 'option',
+                'name'           => 'Option 1',
+                'option_order'   => 5,
+            )
+        );
+
+        $field = new BP_XProfile_Field( $f );
+
+        $this->assertEquals( $parent, $field->parent_id );
+        $this->assertNotEquals( 0, $field->parent_id );
+
+        $field->name = 'Option 2';
+        $field->save(); // Perform the `UPDATE` query. The reason for the bug.
+
+        // Fetch the new DB value.
+        $field = new BP_XProfile_Field( $f );
+
+        $this->assertNotEquals( 0, $field->parent_id );
+        $this->assertEquals( $parent, $field->parent_id );
+    }
+
+    /**
      * @group xprofile_insert_field
      */