Changeset 13775

Timestamp:

03/22/2024 08:40:31 AM (14 months ago)

Author:

imath

Message:

Remove the tool to repair the members last activity tracker

In version 2.0 we decided to stop using the last_activity user meta in favor of tracing this information as an activity type having the same name. Meaning we stopped inserting this user meta for new members or any member of a community if the first BuddyPress installed version is upper than 1.9.

When upgrading from a version < 2.0 to the 2.0 version, the bp_last_activity_migrate() function is there to use the user meta to populate the activity table with corresponding last_activity activities.

We also created a repair tool in case the above upgrade task failed. This tool became obsolete but we forgot to remove it. It's now very problematic if an Admin user uses this tool as it will delete all last_activity activities but will fail at finding users having the last_activity meta.

To stop the spread, we decided to remove this tool during a minor release (12.4.0) as we felt it was an emergency.

Props vapvarun

See #9096 (trunk)

Location:

trunk/src/bp-core

Files:

• admin/bp-core-admin-tools.php (modified) (2 diffs)
• deprecated/12.0.php (modified) (1 diff)

trunk/src/bp-core/admin/bp-core-admin-tools.php

@@ -111 +111 @@
         __( 'Repair total members count.', 'buddypress' ),
         'bp_admin_repair_count_members',
-    );
-
-    $repair_list[25] = array(
-        'bp-last-activity',
-        __( 'Repair member "last activity" data.', 'buddypress' ),
-        'bp_admin_repair_last_activity',
     );
 
@@ -471 +465 @@
     delete_transient( 'bp_active_member_count' );
     bp_core_get_active_member_count();
-    return array( 0, sprintf( $statement, __( 'Complete!', 'buddypress' ) ) );
-}
-
-/**
- * Repair user last_activity data.
- *
- * Re-runs the migration from usermeta introduced in BP 2.0.
- *
- * @since 2.0.0
- */
-function bp_admin_repair_last_activity() {
-    /* translators: %s: the result of the action performed by the repair tool */
-    $statement = __( 'Determining last activity dates for each user… %s', 'buddypress' );
-    bp_last_activity_migrate();
     return array( 0, sprintf( $statement, __( 'Complete!', 'buddypress' ) ) );
 }

trunk/src/bp-core/deprecated/12.0.php

@@ -1621 +1621 @@
     return apply_filters( 'bp_core_get_all_posts_for_user', array( $all_posts ), '12.0.0' );
 }
+
+/**
+ * Repair user last_activity data.
+ *
+ * Re-runs the migration from usermeta introduced in BP 2.0.
+ *
+ * @since 2.0.0
+ * @deprecated 12.4.0
+ */
+function bp_admin_repair_last_activity() {
+    _deprecated_function( __FUNCTION__, '12.4.0' );
+    return array();
+}