Changeset 13744

Timestamp:

02/29/2024 07:29:20 AM (11 months ago)

Author:

imath

Message:

BP Member’s nav: reset primary nav item links when a user is displayed

Since 12.0, the member’s nav item links are no more initialized with the logged-in user links but are left empty and built using the BP Rewrites API. It generated a compatibility issue when the BP Legacy URL parser is in use (eg: when the BP Classic Add-on is active): the BP Member’s nav used to populate a custom WP Nav Menu was wrongly using the displayed member’s links instead of the logged-in user ones.

Making sure to reset these links in favor of the logged-in user ones in such a case is now necessary during the custom WP Nav Menu generation process.

Props vapvarun espellcaste

See #9108 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/237

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (1 diff)

trunk/src/bp-core/bp-core-functions.php

@@ -2792 +2792 @@
 
     if ( 'rewrites' !== bp_core_get_query_parser() ) {
-        $bp_menu_items = $bp->members->nav->get_primary();
+        $primary_items     = $bp->members->nav->get_primary();
+        $user_is_displayed = bp_is_user();
+
+        foreach( $primary_items as $primary_item ) {
+            $current_user_link = $primary_item['link'];
+
+            // When displaying a user, reset the primary item link.
+            if ( $user_is_displayed ) {
+                $current_user_link = bp_loggedin_user_url( bp_members_get_path_chunks( array( $primary_item['slug'] ) ) );
+            }
+
+            $bp_menu_items[] = array(
+                'name' => $primary_item['name'],
+                'slug' => $primary_item['slug'],
+                'link' => $current_user_link,
+            );
+        }
     } else {
         $members_navigation = bp_get_component_navigations();