Changeset 13716 for trunk/src/bp-members/bp-members-blocks.php

Timestamp:

01/28/2024 06:19:59 PM (2 years ago)

Author:

imath

Message:

BP Blocks: make sure default block titles can be translated

Some of the BP Blocks are using a title attribute into their block.json. Unfortunately, block attributes do not seem to be include in the translatable strings of the WP Block Metadata API.

To fix this, all block.json title attributes now default to an empty string & the default title value is handled within the PHP callback to render the block.

For the specific case of the Latest Activities block, this commit also fixes some errors that were preventing it to be able to select the list of Activity types to include into the rendered activities.

See #9074 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/223

File:

• trunk/src/bp-members/bp-members-blocks.php (modified) (6 diffs)

trunk/src/bp-members/bp-members-blocks.php

@@ -392 +392 @@
                 $attributes,
                 array(
-                        'title'         => __( 'Members', 'buddypress' ),
+                        'title'         => '',
                         'maxMembers'    => 5,
                         'memberDefault' => 'active',
@@ -398 +398 @@
                 )
         );
+
+        if ( ! $block_args['title'] ) {
+                $block_args['title'] = __( 'Members', 'buddypress' );
+        }
 
         $classnames         = 'widget_bp_core_members_widget buddypress widget';
@@ -699 +703 @@
                 $attributes,
                 array(
-                        'title'      => __( 'Who\'s Online', 'buddypress' ),
+                        'title'      => '',
                         'maxMembers' => 15,
                         'noMembers'  => __( 'There are no users currently online', 'buddypress' ),
@@ -708 +712 @@
 
         $block_args['type'] = 'online';
+
+        if ( ! $block_args['title'] ) {
+                $block_args['title'] = __( 'Who\'s Online', 'buddypress' );
+        }
 
         return bp_members_render_members_avatars_block( $block_args );
@@ -724 +732 @@
                 $attributes,
                 array(
-                        'title'      => __( 'Recently Active Members', 'buddypress' ),
+                        'title'      => '',
                         'maxMembers' => 15,
                         'noMembers'  => __( 'There are no recently active members', 'buddypress' ),
@@ -734 +742 @@
         $block_args['type'] = 'active';
 
+        if ( ! $block_args['title'] ) {
+                $block_args['title'] = __( 'Recently Active Members', 'buddypress' );
+        }
+
         return bp_members_render_members_avatars_block( $block_args );
 }