Changeset 13687

Timestamp:

01/03/2024 04:44:33 AM (18 months ago)

Author:

imath

Message:

Add directory post type entries to "page on front" choices if needed

When the rewrites URL parser is in use, to preserve the possibility to use a BuddyPress directory as the site's front page, we need to append the corresponding post type IDs to the available pages listed into the WP "page on front" reading setting as BP Directories are stored as buddypress post types instead of the page one.

On the other hand, when the legacy URL parser is in use (eg: BP Classic is active), to prevent duplicates, it's important to leave the "page on front" reading setting choices the way WP sets it as BP Directories are stored as page post types.

Props emaralive

See #9052 (trunk)

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (1 diff)

trunk/src/bp-core/bp-core-filters.php

@@ -957 +957 @@
  */
 function bp_core_include_directory_on_front( $pages = array(), $args = array() ) {
+    // Prevent duplicate "page on front" option values when the 'legacy' BuddyPress URL Parser is in use.
+    if ( 'rewrites' !== bp_core_get_query_parser() ) {
+        return $pages;
+    }
+
     $is_page_on_front_dropdown = false;