Changeset 13637

Timestamp:

11/08/2023 08:21:40 AM (2 years ago)

Author:

imath

Message:

Refresh permalinks when a component having a directory is activated

Fixes #9020
Closes ​https://github.com/buddypress/buddypress/pull/188

Location:

trunk/src/bp-core

Files:

• admin/bp-core-admin-components.php (modified) (2 diffs)
• bp-core-update.php (modified) (1 diff)

trunk/src/bp-core/admin/bp-core-admin-components.php

@@ -300 +300 @@
 
     // Bail if not saving settings.
-    if ( ! isset( $_POST['bp-admin-component-submit'] ) )
+    if ( ! isset( $_POST['bp-admin-component-submit'] ) ) {
         return;
+    }
 
     // Bail if nonce fails.
-    if ( ! check_admin_referer( 'bp-admin-component-setup' ) )
+    if ( ! check_admin_referer( 'bp-admin-component-setup' ) ) {
         return;
+    }
 
     // Settings form submitted, now save the settings. First, set active components.
@@ -323 +325 @@
         bp_core_add_page_mappings( $bp->active_components );
         bp_update_option( 'bp-active-components', $bp->active_components );
+
+        // Force permalinks to be refreshed at next page load if one of the components is using a directory page.
+        if ( array_intersect_key( $bp->active_components, bp_core_get_directory_page_ids( 'active' ) ) ) {
+            bp_delete_rewrite_rules();
+        }
     }
 
     // Where are we redirecting to?
-    $base_url = bp_get_admin_url( add_query_arg( array( 'page' => 'bp-components', 'updated' => 'true' ), 'admin.php' ) );
+    $base_url = bp_get_admin_url(
+        add_query_arg(
+            array(
+                'page'    => 'bp-components',
+                'updated' => 'true',
+            ),
+            'admin.php'
+        )
+    );
 
     // Redirect.
-    wp_redirect( $base_url );
-    die();
+    wp_safe_redirect( $base_url );
+    exit;
 }
 add_action( 'bp_admin_init', 'bp_core_admin_components_settings_handler' );

trunk/src/bp-core/bp-core-update.php

@@ -905 +905 @@
             }
 
-            // Finally make sure to rebuilt permalinks at next page load.
+            // Force permalinks to be refreshed at next page load.
             bp_delete_rewrite_rules();
         }