Changeset 13636 for trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

Timestamp:

11/07/2023 10:41:34 PM (15 months ago)

Author:

imath

Message:

Improve the favorites management using the WP Meta API

• Introduce bp_activity_register_user_favorites_meta() to register the user meta and define sanitization callback.
• Introduce bp_activity_sanitize_user_favorites_meta() to do the sanitization job.
• Improve Ajax callbacks about favoriting/unfavoriting activities in template packs.

Props emaralive, dcavins

Fixes #9021
Closes ​https://github.com/buddypress/buddypress/pull/189

File:

• trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

@@ -104 +104 @@
     $activity_id   = (int) $_POST['id'];
     $activity_item = new BP_Activity_Activity( $activity_id );
-    if ( ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
-        wp_send_json_error();
-    }
-
-    if ( bp_activity_add_user_favorite( $_POST['id'] ) ) {
+    if ( empty( $activity_item->id ) || ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
+        wp_send_json_error();
+    }
+
+    if ( bp_activity_add_user_favorite( $activity_id ) ) {
         $response = array( 'content' => __( 'Remove Favorite', 'buddypress' ) );
 
@@ -150 +150 @@
     }
 
-    if ( bp_activity_remove_user_favorite( $_POST['id'] ) ) {
+    $activity_id = (int) $_POST['id'];
+
+    if ( bp_activity_remove_user_favorite( $activity_id ) ) {
         $response = array( 'content' => __( 'Mark as Favorite', 'buddypress' ) );