Changeset 13636 for trunk/src/bp-templates/bp-legacy/buddypress-functions.php

Timestamp:

11/07/2023 10:41:34 PM (3 years ago)

Author:

imath

Message:

Improve the favorites management using the WP Meta API

• Introduce bp_activity_register_user_favorites_meta() to register the user meta and define sanitization callback.
• Introduce bp_activity_sanitize_user_favorites_meta() to do the sanitization job.
• Improve Ajax callbacks about favoriting/unfavoriting activities in template packs.

Props emaralive, dcavins

Fixes #9021
Closes ​https://github.com/buddypress/buddypress/pull/189

File:

• trunk/src/bp-templates/bp-legacy/buddypress-functions.php (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1278 +1278 @@
         $activity_id   = (int) $_POST['id'];
         $activity_item = new BP_Activity_Activity( $activity_id );
-        if ( ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
-                return;
-        }
-
-        if ( bp_activity_add_user_favorite( $_POST['id'] ) )
-                _e( 'Remove Favorite', 'buddypress' );
-        else
-                _e( 'Favorite', 'buddypress' );
+        if ( empty( $activity_item->id ) || ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
+                return;
+        }
+
+        if ( bp_activity_add_user_favorite( $activity_id ) ) {
+                esc_html_e( 'Remove Favorite', 'buddypress' );
+        } else {
+                esc_html_e( 'Favorite', 'buddypress' );
+        }
 
         exit;
@@ -1312 +1313 @@
         }
 
-        if ( bp_activity_remove_user_favorite( $_POST['id'] ) )
-                _e( 'Favorite', 'buddypress' );
-        else
-                _e( 'Remove Favorite', 'buddypress' );
+        $activity_id = (int) $_POST['id'];
+
+        if ( bp_activity_remove_user_favorite( $activity_id ) ) {
+                esc_html_e( 'Favorite', 'buddypress' );
+        } else {
+                esc_html_e( 'Remove Favorite', 'buddypress' );
+        }
 
         exit;