Changeset 13632

Timestamp:

11/05/2023 07:32:10 AM (15 months ago)

Author:

imath

Message:

Prevent potential 3rd party plugins/themes issues for new installs

• Load 12.0 deprecated functions even in new installs.
• Add an Admin Notification to inform about BP Classic: the BP backwards compatibility Add-on.

Props emaralive, dcavins

Fixes #9015
Closes ​https://github.com/buddypress/buddypress/pull/183

Location:

trunk

Files:

• src/bp-core/bp-core-functions.php (modified) (3 diffs)
• src/bp-core/bp-core-update.php (modified) (1 diff)
• tests/phpunit/testcases/core/functions.php (modified) (1 diff)

trunk/src/bp-core/bp-core-functions.php

@@ -4886 +4886 @@
     $load_latest_deprecated = $initial_version < $current_version;
 
-    // We don't load deprecated functions for new installs.
+    // New installs.
     if ( ! $load_latest_deprecated ) {
         // Run some additional checks if PHPUnit is running.
@@ -4905 +4905 @@
             }
         }
-        return array();
+
+        // Only load 12.0 deprecated functions.
+        return array( '12.0' );
     }
 
@@ -5120 +5122 @@
                 __( 'If any of the above items are true, we strongly advise you to install and activate the Classic Add-on before updating to BuddyPress 12.0.0.', 'buddypress' ),
                 'version' => 11.4,
-        )
+        ),
+        'bp120-new-installs-warning' => (object) array(
+            'id'      => 'bp120-new-installs-warning',
+            'href'    => add_query_arg(
+                array(
+                    'tab'  => 'bp-add-ons',
+                    'show' => 'bp-classic',
+                    'n'    => 'bp120-new-installs-warning'
+                ),
+                bp_get_admin_url( 'plugin-install.php' )
+            ),
+            'text'    => __( 'Get The BP Classic Add-on', 'buddypress' ),
+            'title'   => __( 'Thank you for installing BuddyPress 12.0!', 'buddypress' ),
+            'content' => __( 'BuddyPress 12.0 introduces major core changes, overhauling the way that BuddyPress builds and parses URLs.', 'buddypress' ) . '<br><br>' .
+                __( 'If you find that your site is not working correctly with the new version, try installing the new BP Classic Add-on that adds backwards compatibility for plugins and themes that have not yet been updated to work with BuddyPress 12.0.', 'buddypress' ),
+                'version' => 12.0,
+        ),
     );
 

trunk/src/bp-core/bp-core-update.php

@@ -204 +204 @@
     }
 
-    // Install BP schema and activate only Activity and XProfile.
+    // Install BP schema and activate default components.
     if ( bp_is_install() ) {
         // Set the first BP major version the plugin was installed.
         bp_update_option( '_bp_initial_major_version', bp_get_major_version() );
 
-        // Apply schema and set Activity and XProfile components as active.
+        // Add an unread Admin notification.
+        if ( 13422 === bp_get_db_version() ) {
+            $unread   = bp_core_get_unread_admin_notifications();
+            $unread[] = 'bp120-new-installs-warning';
+
+            bp_update_option( 'bp_unread_admin_notifications', $unread );
+        }
+
+        // Apply schema and set default components as active.
         bp_core_install( $default_components );
         bp_update_option( 'bp-active-components', $default_components );

trunk/tests/phpunit/testcases/core/functions.php

@@ -875 +875 @@
         $versions        = bp_get_deprecated_functions_versions();
 
-        // When current version is the initial version, we shouldn't load deprecated functions files.
-        $this->assertTrue( is_array( $versions ) && ! $versions, 'Please check the list of `$deprecated_functions_versions` in `bp_get_deprecated_functions_versions()`. There should be one for each file of the `/src/bp-core/deprecated` directory.' );
+        // When current version is the initial version, we should only load 12.0 deprecated functions file.
+        $this->assertSame( $versions, array( '12.0' ), 'Please check the list of `$deprecated_functions_versions` in `bp_get_deprecated_functions_versions()`. There should be one for each file of the `/src/bp-core/deprecated` directory.' );
 
         // We should load the 2 lasts deprecated functions files.