Changeset 13592

Timestamp:

10/11/2023 02:09:00 AM (2 years ago)

Author:

imath

Message:

Clear the Groups cache incrementor after a group member removal

Do reset the Groups cache incrementor once the 'groups_member_after_remove' action is fired. Although in most configs this extra action is not needed, adding it makes sure the corresponding cached results is cleared when using the Memcached plugin.

Props iandunn

Fixes #9000
Closes ​https://github.com/buddypress/buddypress/pull/171

Location:

trunk

Files:

• src/bp-groups/bp-groups-cache.php (modified) (1 diff)
• tests/phpunit/testcases/groups/cache.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-cache.php

@@ -326 +326 @@
     return bp_core_reset_incrementor( 'bp_groups' );
 }
-add_action( 'groups_group_after_save', 'bp_groups_reset_cache_incrementor' );
-add_action( 'bp_groups_delete_group',  'bp_groups_reset_cache_incrementor' );
-add_action( 'updated_group_meta',      'bp_groups_reset_cache_incrementor' );
-add_action( 'deleted_group_meta',      'bp_groups_reset_cache_incrementor' );
-add_action( 'added_group_meta',        'bp_groups_reset_cache_incrementor' );
+add_action( 'groups_group_after_save',    'bp_groups_reset_cache_incrementor' );
+add_action( 'bp_groups_delete_group',     'bp_groups_reset_cache_incrementor' );
+add_action( 'updated_group_meta',         'bp_groups_reset_cache_incrementor' );
+add_action( 'deleted_group_meta',         'bp_groups_reset_cache_incrementor' );
+add_action( 'added_group_meta',           'bp_groups_reset_cache_incrementor' );
+add_action( 'groups_member_after_remove', 'bp_groups_reset_cache_incrementor' );
 
 /**

trunk/tests/phpunit/testcases/groups/cache.php

@@ -6 +6 @@
  */
 class BP_Tests_Group_Cache extends BP_UnitTestCase {
+
     /**
      * @group bp_groups_update_meta_cache
@@ -280 +281 @@
         $this->assertEquals( 3, BP_Groups_Group::get_total_group_count() );
     }
+
+    /**
+     * @ticket BP9000
+     */
+    public function test_groups_get_groups_for_user_cache_once_left() {
+        $g = self::factory()->group->create();
+        $u = self::factory()->user->create();
+
+        groups_join_group( $g, $u );
+        $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+        $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+        $this->assertContains( $g, $u_group_ids );
+
+        groups_leave_group( $g, $u );
+        $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+        $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+        $this->assertNotContains( $g, $u_group_ids );
+    }
+
+    /**
+     * @ticket BP9000
+     */
+    public function test_groups_get_groups_for_user_cache_once_removed() {
+        $g = self::factory()->group->create();
+        $u = self::factory()->user->create();
+
+        groups_join_group( $g, $u );
+        $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+        $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+        $this->assertContains( $g, $u_group_ids );
+
+        add_filter( 'bp_is_item_admin', '__return_true' );
+        groups_remove_member( $u, $g );
+        remove_filter( 'bp_is_item_admin', '__return_true' );
+
+        $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+        $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+        $this->assertNotContains( $g, $u_group_ids );
+    }
 }