Changeset 13534 for trunk/src/bp-members/classes/class-bp-members-component.php

Timestamp:

07/30/2023 06:48:08 AM (3 years ago)

Author:

imath

Message:

Restore the Member’s activity single view

A regression introduced in [13512] was preventing single activities to successfully load into the BP Nouveau Template Pack. We need to only perform the parse query check when viewing a single user. In the case of a single activity there is no need to check for an existing Member’s (sub)navigation item.

See #8932
Fixes #8956
Closes ​https://github.com/buddypress/buddypress/pull/143

File:

• trunk/src/bp-members/classes/class-bp-members-component.php (modified) (1 diff)

trunk/src/bp-members/classes/class-bp-members-component.php

@@ -978 +978 @@
          */
         public function check_parsed_query() {
-                $single_item_component = '';
                 if ( bp_is_user() ) {
                         $single_item_component = bp_current_component();
-                }
-
-                $single_item_action = '';
-                if ( $single_item_component ) {
-                        $single_item_action = bp_current_action();
-                }
-
-                $bp = buddypress();
-                if ( isset( $bp->{$single_item_component}, $bp->{$single_item_component}->sub_nav ) ) {
-                        $screen_functions = wp_list_pluck( $bp->{$single_item_component}->sub_nav, 'screen_function', 'slug' );
-
-                        if ( ! $single_item_action || ! isset( $screen_functions[ $single_item_action ] ) || ! is_callable( $screen_functions[ $single_item_action ] ) ) {
-                                bp_do_404();
+
+                        $single_item_action = '';
+                        if ( $single_item_component ) {
+                                $single_item_action = bp_current_action();
+                        }
+
+                        // Viewing a single activity.
+                        if ( 'activity' === $single_item_component && is_numeric( $single_item_action ) ) {
                                 return;
+                        }
+
+                        $bp = buddypress();
+                        if ( isset( $bp->{$single_item_component}, $bp->{$single_item_component}->sub_nav ) ) {
+                                $screen_functions = wp_list_pluck( $bp->{$single_item_component}->sub_nav, 'screen_function', 'slug' );
+
+                                if ( ! $single_item_action || ! isset( $screen_functions[ $single_item_action ] ) || ! is_callable( $screen_functions[ $single_item_action ] ) ) {
+                                        bp_do_404();
+                                        return;
+                                }
                         }
                 }