Changeset 13521 for trunk/src/bp-groups/classes/class-bp-groups-component.php

Timestamp:

07/20/2023 02:44:22 AM (15 months ago)

Author:

imath

Message:

Ensure the way the single group canonical stack is set is consistent

If the manage context does not need the current action to get the customized slugs for action variables, the read context does.

Moreover, as the current group is not set during the creation process, we don't need to get customized action variables for the create context.

Fixes #8940
See #4954
Closes ​https://github.com/buddypress/buddypress/pull/134

File:

• trunk/src/bp-groups/classes/class-bp-groups-component.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -576 +576 @@
 
             if ( ! empty( $bp->action_variables ) ) {
+                $chunks               = array( $current_action, $bp->action_variables );
                 $key_action_variables = 'single_item_action_variables';
 
                 if ( bp_is_group_admin_page() ) {
                     $context = 'manage';
-                } elseif ( bp_is_group_create() ) {
-                    $context              = 'create';
-                    $key_action_variables = 'create_single_item_variables';;
-                }
-
-                $path_chunks                             = bp_groups_get_path_chunks( $bp->action_variables, $context );
+                    array_shift( $chunks );
+                }
+
+                $path_chunks                             = bp_groups_get_path_chunks( $chunks, $context );
                 $bp->canonical_stack['action_variables'] = bp_action_variables();