Changeset 13519 for trunk/src/bp-core/bp-core-template-loader.php

Timestamp:

07/16/2023 03:43:26 PM (20 months ago)

Author:

imath

Message:

Make sure bp_core_new_nav_default() is ready for the BP Rewrites API

• In case plain permalinks are used, use the $GLOBALS['wp']->query_string to set the buddypress()->unfiltered_uri global.
• Do not edit sub nav links when calling bp_core_new_nav_default() if the URL parser is set to 'rewrites'.
• Avoid a PHP notice if the new sub nav object misses the slug and/or the link properties.

Props corzel

See #4954
Fixes #8936
Closes ​https://github.com/buddypress/buddypress/pull/130

File:

• trunk/src/bp-core/bp-core-template-loader.php (modified) (1 diff)

trunk/src/bp-core/bp-core-template-loader.php

@@ -570 +570 @@
 
     if ( ! $bp->unfiltered_uri ) {
-        $bp->unfiltered_uri        = explode( '/', $GLOBALS['wp']->request );
+        $unfiltered_uri = explode( '/', $GLOBALS['wp']->request );
+
+        // Make sure to set the BP unfiltered_uri global when plain links are used.
+        if ( ! bp_has_pretty_urls() ) {
+            $bp_directories = array();
+            foreach ( $bp->pages as $component_id => $page_properties ) {
+                if ( isset( $bp->{$component_id}->rewrite_ids['directory'] ) ) {
+                    $bp_directories[ $bp->{$component_id}->rewrite_ids['directory'] ] = $page_properties->slug;
+                } elseif ( 'activate' === $component_id || 'register' === $component_id ) {
+                    $bp_directories[ 'bp_member_' . $component_id ] = $page_properties->slug;
+                }
+            }
+
+            $url_query_chunks = bp_parse_args( $GLOBALS['wp']->query_string, array() );
+            $directory        = key( $url_query_chunks );
+            if ( isset( $bp_directories[ $directory ] ) ) {
+                $url_query_chunks[ $directory ] = $bp_directories[ $directory ];
+            }
+
+            $unfiltered_uri = array_values( $url_query_chunks );
+        }
+
+        $bp->unfiltered_uri        = $unfiltered_uri;
         $bp->unfiltered_uri_offset = 0;
     }