Changeset 13507 for trunk/src/bp-core/bp-core-buddybar.php

Timestamp:

06/25/2023 05:18:41 PM (2 years ago)

Author:

imath

Message:

Fully deprecate bp_nav & bp_options_nav BP globals

These back compatibility mechanism, which was in BP since version 2.6, has moved to the BP Classic plugin.

Fixes #8927
Closes ​https://github.com/buddypress/buddypress/pull/121

File:

• trunk/src/bp-core/bp-core-buddybar.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-buddybar.php

@@ -858 +858 @@
     $screen_functions = $bp->{$component}->nav->delete_nav( $slug );
 
-    // Reset backcompat nav items so that subsequent references will be correct.
-    $bp->bp_nav->reset();
-    $bp->bp_options_nav->reset();
+    /**
+     * Fires when a nav item was removed from navigation.
+     *
+     * @since 12.0.0
+     *
+     * @param false|callable|array $screen_functions False, the screen function(s) on success.
+     * @param string               $slug             The slug of the primary navigation item.
+     * @param string|null          $component        The component the navigation is attached to. Defaults to 'members'.
+     */
+    do_action( 'bp_core_removed_nav_item', $screen_functions, $slug, $component );
 
     if ( ! is_array( $screen_functions ) ) {
@@ -907 +914 @@
     $screen_functions = $bp->{$component}->nav->delete_nav( $slug, $parent_slug );
 
-    // Reset backcompat nav items so that subsequent references will be correct.
-    $bp->bp_nav->reset();
-    $bp->bp_options_nav->reset();
+    /**
+     * Fires when a subnav item was removed from navigation.
+     *
+     * @since 12.0.0
+     *
+     * @param false|callable|array $screen_functions False, the screen function(s) on success.
+     * @param string               $parent_slug The slug of the primary navigation item.
+     * @param string               $slug        The slug of the secondary item to be removed.
+     * @param string|null          $component   The component the navigation is attached to. Defaults to 'members'.
+     */
+    do_action( 'bp_core_removed_subnav_item', $screen_functions, $parent_slug, $slug, $component );
 
     if ( ! is_array( $screen_functions ) ) {