Changeset 13503 for trunk/src/bp-messages/actions/compose.php

Timestamp:

06/18/2023 04:11:04 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: optimize the code used to build URLs

The bp_members_get_path_chunks() & bp_groups_get_path_chunks() functions are making sure URL chunks are customized according to the slugs settings. Instead of redoing at many places all or some of the operations performed by these functions, update the code to build URLs so that it uses these functions.

See #4954
Fixes #8923
Closes ​https://github.com/buddypress/buddypress/pull/117

File:

• trunk/src/bp-messages/actions/compose.php (modified) (3 diffs)

trunk/src/bp-messages/actions/compose.php

@@ -44 +44 @@
 
         // Setup the link to the logged-in user's messages.
-        $message_slug        = bp_get_messages_slug();
-        $custom_message_slug = bp_rewrites_get_slug( 'members', 'member_' . $message_slug, $message_slug );
-        $path_chunks         = array(
-            'single_item_component' => $custom_message_slug,
-        );
+        $path_chunks = array( bp_get_messages_slug() );
 
         // Site-wide notice.
@@ -55 +51 @@
             // Attempt to save the notice and redirect to notices.
             if ( messages_send_notice( $_POST['subject'], $_POST['content'] ) ) {
-                $success                           = true;
-                $feedback                          = __( 'Notice successfully created.', 'buddypress' );
-                $path_chunks['single_item_action'] = bp_rewrites_get_slug( 'members', 'member_' . $message_slug . '_notices', 'notices' );
-                $redirect_to = bp_loggedin_user_url( $path_chunks );
+                $success       = true;
+                $feedback      = __( 'Notice successfully created.', 'buddypress' );
+                $path_chunks[] = 'notices';
+                $redirect_to   = bp_loggedin_user_url( bp_members_get_path_chunks( $path_chunks ) );
 
             // Notice could not be sent.
@@ -93 +89 @@
             // Send the message and redirect to it.
             if ( true === is_int( $send ) ) {
-                $success                                     = true;
-                $feedback                                    = __( 'Message successfully sent.', 'buddypress' );
-                $path_chunks['single_item_action']           = bp_rewrites_get_slug( 'members', 'member_' . $message_slug . '_view', 'view' );
-                $path_chunks['single_item_action_variables'] = array( $send );
-                $redirect_to                                 = bp_loggedin_user_url( $path_chunks );
+                $success       = true;
+                $feedback      = __( 'Message successfully sent.', 'buddypress' );
+                $path_chunks[] = 'view';
+                $path_chunks[] = array( $send );
+                $redirect_to   = bp_loggedin_user_url( bp_members_get_path_chunks( $path_chunks ) );
 
             // Message could not be sent.