Changeset 13495 for trunk/src/bp-settings/classes/class-bp-settings-component.php

Timestamp:

06/02/2023 02:05:08 AM (3 years ago)

Author:

imath

Message:

Prevent potential issues with late_includes() in Component classes

Use require_once instead of require to load action & screen files.

See #4954
Fixes #8910
Closes ​https://github.com/buddypress/buddypress/pull/112

File:

• trunk/src/bp-settings/classes/class-bp-settings-component.php (modified) (2 diffs)

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -73 +73 @@
         if ( is_user_logged_in() ) {
             if ( ! bp_current_action() || bp_is_current_action( 'general' ) ) {
-                require $this->path . 'bp-settings/actions/general.php';
+                require_once $this->path . 'bp-settings/actions/general.php';
 
             // Specific to post requests.
             } elseif ( bp_is_post_request() && in_array( bp_current_action(), $actions, true ) ) {
-                require $this->path . 'bp-settings/actions/' . bp_current_action() . '.php';
+                require_once $this->path . 'bp-settings/actions/' . bp_current_action() . '.php';
             }
         }
@@ -83 +83 @@
         // Screens - User profile integration.
         if ( bp_is_user() ) {
-            require $this->path . 'bp-settings/screens/general.php';
+            require_once $this->path . 'bp-settings/screens/general.php';
 
             // Sub-nav items.
             if ( in_array( bp_current_action(), $actions, true ) ) {
-                require $this->path . 'bp-settings/screens/' . bp_current_action() . '.php';
+                require_once $this->path . 'bp-settings/screens/' . bp_current_action() . '.php';
             }
         }