Changeset 13495 for trunk/src/bp-members/classes/class-bp-members-component.php

Timestamp:

06/02/2023 02:05:08 AM (3 years ago)

Author:

imath

Message:

Prevent potential issues with late_includes() in Component classes

Use require_once instead of require to load action & screen files.

See #4954
Fixes #8910
Closes ​https://github.com/buddypress/buddypress/pull/112

File:

• trunk/src/bp-members/classes/class-bp-members-component.php (modified) (5 diffs)

trunk/src/bp-members/classes/class-bp-members-component.php

@@ -152 +152 @@
             // Actions - Random member handler.
             if ( isset( $_GET['random-member'] ) ) {
-                require $this->path . 'bp-members/actions/random.php';
+                require_once $this->path . 'bp-members/actions/random.php';
             }
 
             // Screens - Directory.
             if ( bp_is_members_directory() ) {
-                require $this->path . 'bp-members/screens/directory.php';
+                require_once $this->path . 'bp-members/screens/directory.php';
             }
         }
@@ -163 +163 @@
         // Members - User main nav screen.
         if ( bp_is_user() ) {
-            require $this->path . 'bp-members/screens/profile.php';
+            require_once $this->path . 'bp-members/screens/profile.php';
 
             // Action - Delete avatar.
             if ( is_user_logged_in()&& bp_is_user_change_avatar() && bp_is_action_variable( 'delete-avatar', 0 ) ) {
-                require $this->path . 'bp-members/actions/delete-avatar.php';
+                require_once $this->path . 'bp-members/actions/delete-avatar.php';
             }
 
@@ -174 +174 @@
                 in_array( bp_current_action(), array( 'change-avatar', 'change-cover-image' ), true )
             ) {
-                require $this->path . 'bp-members/screens/' . bp_current_action() . '.php';
+                require_once $this->path . 'bp-members/screens/' . bp_current_action() . '.php';
             }
         }
@@ -186 +186 @@
         if ( bp_is_register_page() || bp_is_activation_page() ) {
             if ( bp_is_register_page() ) {
-                require $this->path . 'bp-members/screens/register.php';
+                require_once $this->path . 'bp-members/screens/register.php';
             } else {
-                require $this->path . 'bp-members/screens/activate.php';
+                require_once $this->path . 'bp-members/screens/activate.php';
             }
 
@@ -199 +199 @@
             // Actions.
             if ( isset( $_POST['members_invitations'] ) ) {
-                require $this->path . 'bp-members/actions/invitations-bulk-manage.php';
+                require_once $this->path . 'bp-members/actions/invitations-bulk-manage.php';
             }
 
             // Screens.
-            require $this->path . 'bp-members/screens/invitations.php';
+            require_once $this->path . 'bp-members/screens/invitations.php';
         }
     }