Changeset 13492 for trunk/src/bp-groups/classes/class-bp-groups-component.php

Timestamp:

05/29/2023 05:51:12 AM (16 months ago)

Author:

imath

Message:

Make sure BP_Component::parse_query() always run

Only running it when BP Rewrites are on is not the right way to go as some plugins might have been using the WP Rewrites API for a while and might have extended this method from their component's class.

Instead of only running this method if BP Rewrites are on, we're adding a URL parser check inside each component having a directory to figure out whether it's needed to set BP URI globals.

See #4954
Fixes #8908
Closes ​https://github.com/buddypress/buddypress/pull/109

File:

• trunk/src/bp-groups/classes/class-bp-groups-component.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -1067 +1067 @@
      */
     public function parse_query( $query ) {
+        /*
+         * If BP Rewrites are not in use, no need to parse BP URI globals another time.
+         * Legacy Parser should have already set these.
+         */
+        if ( 'rewrites' !== bp_core_get_query_parser() ) {
+            return parent::parse_query( $query );
+        }
+
         if ( bp_is_directory_homepage( $this->id ) ) {
             $query->set( $this->rewrite_ids['directory'], 1 );