Changeset 13492 for trunk/src/bp-core/classes/class-bp-component.php

Timestamp:

05/29/2023 05:51:12 AM (20 months ago)

Author:

imath

Message:

Make sure BP_Component::parse_query() always run

Only running it when BP Rewrites are on is not the right way to go as some plugins might have been using the WP Rewrites API for a while and might have extended this method from their component's class.

Instead of only running this method if BP Rewrites are on, we're adding a URL parser check inside each component having a directory to figure out whether it's needed to set BP URI globals.

See #4954
Fixes #8908
Closes ​https://github.com/buddypress/buddypress/pull/109

File:

• trunk/src/bp-core/classes/class-bp-component.php (modified) (2 diffs)

trunk/src/bp-core/classes/class-bp-component.php

@@ -578 +578 @@
 
         // Allow components to parse the main query.
-        if ( 'rewrites' === bp_core_get_query_parser() ) {
-            /**
-             * Only fire this hook when pretty links are disabled.
-             *
-             * @todo Remove once BP Rewrites merge process is ended.
-             */
-            add_action( 'bp_parse_query',  array( $this, 'parse_query' ), 10 );
-        }
+        add_action( 'bp_parse_query',  array( $this, 'parse_query' ), 10 );
 
         // Generate rewrite rules.
@@ -1236 +1229 @@
      */
     public function parse_query( $query ) {
-        if ( is_buddypress() ) {
+        if ( is_buddypress() && 'rewrites' === bp_core_get_query_parser() ) {
             add_filter( 'posts_pre_query', array( $this, 'pre_query' ), 10, 2 );
         }