Changeset 13492 for trunk/src/bp-core/bp-core-template-loader.php

Timestamp:

05/29/2023 05:51:12 AM (19 months ago)

Author:

imath

Message:

Make sure BP_Component::parse_query() always run

Only running it when BP Rewrites are on is not the right way to go as some plugins might have been using the WP Rewrites API for a while and might have extended this method from their component's class.

Instead of only running this method if BP Rewrites are on, we're adding a URL parser check inside each component having a directory to figure out whether it's needed to set BP URI globals.

See #4954
Fixes #8908
Closes ​https://github.com/buddypress/buddypress/pull/109

File:

• trunk/src/bp-core/bp-core-template-loader.php (modified) (1 diff)

trunk/src/bp-core/bp-core-template-loader.php

@@ -566 +566 @@
     }
 
-    // Set some needed URI globals.
-    $bp                        = buddypress();
-    $bp->unfiltered_uri        = explode( '/', $GLOBALS['wp']->request );
-    $bp->unfiltered_uri_offset = 0;
+    // Eventually Set some missing URI globals.
+    $bp = buddypress();
+
+    if ( ! $bp->unfiltered_uri ) {
+        $bp->unfiltered_uri        = explode( '/', $GLOBALS['wp']->request );
+        $bp->unfiltered_uri_offset = 0;
+    }
 
     /**