Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
05/07/2023 11:36:50 AM (12 months ago)
Author:
imath
Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

  • Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
  • Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
  • Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
  • Remove the Page settings Admin help tab & move it into BP Classic
  • Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-templates/bp-nouveau/includes/template-tags.php

    r13443 r13471  
    44 *
    55 * @since 3.0.0
    6  * @version 10.0.0
     6 * @version 12.0.0
    77 */
    88
     
    10371037
    10381038        if ( 'directory' === $bp_nouveau->displayed_nav ) {
    1039             $scope = array( 'data-bp-scope' => $nav_item->slug );
     1039            $scope = array(
     1040                'data-bp-scope' => $nav_item->slug
     1041            );
    10401042
    10411043        } elseif ( 'personal' === $bp_nouveau->displayed_nav && ! empty( $nav_item->secondary ) ) {
    1042             $scope = array( 'data-bp-user-scope' => $nav_item->slug );
     1044            $rewrite_id = bp_rewrites_get_custom_slug_rewrite_id( 'members', $nav_item->slug, bp_current_component() );
     1045            $user_scope = $nav_item->slug;
     1046
     1047            if ( $rewrite_id ) {
     1048                $user_scope = str_replace(
     1049                    array( 'bp_member_' . bp_current_component() . '_', '_' ),
     1050                    array( '', '-' ),
     1051                    $rewrite_id
     1052                );
     1053            }
     1054
     1055            $scope = array(
     1056                'data-bp-user-scope' => $nav_item->slug
     1057            );
    10431058
    10441059        } else {
Note: See TracChangeset for help on using the changeset viewer.