Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
05/07/2023 11:36:50 AM (12 months ago)
Author:
imath
Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

  • Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
  • Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
  • Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
  • Remove the Page settings Admin help tab & move it into BP Classic
  • Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-members/classes/class-bp-members-component.php

    r13468 r13471  
    10301030        );
    10311031    }
    1032 
    1033     /**
    1034      * Add the Members directory states.
    1035      *
    1036      * @since 10.0.0
    1037      *
    1038      * @param array   $states Optional. See BP_Component::admin_directory_states() for description.
    1039      * @param WP_Post $post   Optional. See BP_Component::admin_directory_states() for description.
    1040      * @return array          See BP_Component::admin_directory_states() for description.
    1041      */
    1042     public function admin_directory_states( $states = array(), $post = null ) {
    1043         $bp = buddypress();
    1044 
    1045         if ( isset( $bp->pages->members->id ) && (int) $bp->pages->members->id === (int) $post->ID ) {
    1046             $states['page_for_members_directory'] = _x( 'BP Members Page', 'page label', 'buddypress' );
    1047         }
    1048 
    1049         if ( bp_get_signup_allowed() || bp_get_members_invitations_allowed() ) {
    1050             if ( isset( $bp->pages->register->id ) && (int) $bp->pages->register->id === (int) $post->ID ) {
    1051                 $states['page_for_bp_registration'] = _x( 'BP Registration Page', 'page label', 'buddypress' );
    1052             }
    1053 
    1054             if ( isset( $bp->pages->activate->id ) && (int) $bp->pages->activate->id === (int) $post->ID ) {
    1055                 $states['page_for_bp_activation'] = _x( 'BP Activation Page', 'page label', 'buddypress' );
    1056             }
    1057         }
    1058 
    1059         return parent::admin_directory_states( $states, $post );
    1060     }
    10611032}
Note: See TracChangeset for help on using the changeset viewer.