Changeset 13471 for trunk/src/bp-core/classes/class-bp-component.php

Timestamp:

05/07/2023 11:36:50 AM (17 months ago)

Author:

imath

Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

• Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
• Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
• Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
• Remove the Page settings Admin help tab & move it into BP Classic
• Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:

• trunk/src/bp-core/classes/class-bp-component.php (modified) (4 diffs)

trunk/src/bp-core/classes/class-bp-component.php

@@ -600 +600 @@
         }
 
-        // Set directory page states.
-        add_filter( 'bp_admin_display_directory_states', array( $this, 'admin_directory_states' ), 10, 2 );
-
         /**
          * Fires at the end of the setup_actions method inside BP_Component.
@@ -1278 +1275 @@
             $query->is_front_page = false;
             $query->is_page       = false;
-            $query->is_single     = true;
             $query->is_archive    = false;
             $query->is_tax        = false;
+
+            if ( ! is_embed() ) {
+                $query->is_single = true;
+            }
         }
 
@@ -1390 +1390 @@
      *
      * @since 10.0.0
+     * @deprecated 12.0.0
      *
      * @param string[] $states An array of post display states.
@@ -1396 +1397 @@
      */
     public function admin_directory_states( $states = array(), $post = null ) {
-        if ( $this->has_directory ) {
-            /**
-             * Filter here to edit the component's directory states.
-             *
-             * This is a dynamic hook that is based on the component string ID.
-             *
-             * @since 10.0.0
-             *
-             * @param string[] $states An array of post display states.
-             * @param WP_Post  $post   The current post object.
-             */
-            return apply_filters( 'bp_' . $this->id . '_admin_directory_states', $states, $post );
-        }
-
+        _deprecated_function( __METHOD__, '12.0.0' );
         return $states;
     }