Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
05/07/2023 11:36:50 AM (12 months ago)
Author:
imath
Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

  • Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
  • Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
  • Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
  • Remove the Page settings Admin help tab & move it into BP Classic
  • Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-core/classes/class-bp-component.php

    r13468 r13471  
    600600        }
    601601
    602         // Set directory page states.
    603         add_filter( 'bp_admin_display_directory_states', array( $this, 'admin_directory_states' ), 10, 2 );
    604 
    605602        /**
    606603         * Fires at the end of the setup_actions method inside BP_Component.
     
    12781275            $query->is_front_page = false;
    12791276            $query->is_page       = false;
    1280             $query->is_single     = true;
    12811277            $query->is_archive    = false;
    12821278            $query->is_tax        = false;
     1279
     1280            if ( ! is_embed() ) {
     1281                $query->is_single = true;
     1282            }
    12831283        }
    12841284
     
    13901390     *
    13911391     * @since 10.0.0
     1392     * @deprecated 12.0.0
    13921393     *
    13931394     * @param string[] $states An array of post display states.
     
    13961397     */
    13971398    public function admin_directory_states( $states = array(), $post = null ) {
    1398         if ( $this->has_directory ) {
    1399             /**
    1400              * Filter here to edit the component's directory states.
    1401              *
    1402              * This is a dynamic hook that is based on the component string ID.
    1403              *
    1404              * @since 10.0.0
    1405              *
    1406              * @param string[] $states An array of post display states.
    1407              * @param WP_Post  $post   The current post object.
    1408              */
    1409             return apply_filters( 'bp_' . $this->id . '_admin_directory_states', $states, $post );
    1410         }
    1411 
     1399        _deprecated_function( __METHOD__, '12.0.0' );
    14121400        return $states;
    14131401    }
Note: See TracChangeset for help on using the changeset viewer.