Changeset 13471 for trunk/src/bp-core/bp-core-filters.php

Timestamp:

05/07/2023 11:36:50 AM (3 years ago)

Author:

imath

Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

• Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
• Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
• Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
• Remove the Page settings Admin help tab & move it into BP Classic
• Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-filters.php

@@ -948 +948 @@
 
 /**
+ * Eventually append BuddyPress directories to WP Dropdown's pages control.
+ *
+ * @since 12.0.0
+ *
+ * @param WP_Post[] $pages Array of page objects.
+ * @param array     $args  Array of get_pages() arguments.
+ * @return WP_Post[]       Array of page objects, potentially including BP directories.
+ */
+function bp_core_include_directory_on_front( $pages = array(), $args = array() ) {
+    $is_page_on_front_dropdown = false;
+
+    if ( isset( $args['name'] ) ) {
+        $is_page_on_front_dropdown = 'page_on_front' === $args['name'];
+
+        if ( is_customize_preview() ) {
+            $is_page_on_front_dropdown = '_customize-dropdown-pages-page_on_front' === $args['name'];
+        }
+    }
+
+    if ( $is_page_on_front_dropdown ) {
+        $directories = bp_core_get_directory_pages();
+        $null        = '0000-00-00 00:00:00';
+
+        foreach ( (array) $directories as $component => $directory ) {
+            if ( 'activate' === $component || 'register' === $component ) {
+                continue;
+            }
+
+            $post = (object) array(
+                'ID'                    => $directory->id,
+                'post_author'           => 0,
+                'post_date'             => $null,
+                'post_date_gmt'         => $null,
+                'post_content'          => '',
+                'post_title'            => $directory->title,
+                'post_excerpt'          => '',
+                'post_status'           => 'publish',
+                'comment_status'        => 'closed',
+                'ping_status'           => 'closed',
+                'post_password'         => '',
+                'post_name'             => $directory->slug,
+                'pinged'                => '',
+                'to_ping'               => '',
+                'post_modified'         => $null,
+                'post_modified_gmt'     => $null,
+                'post_content_filtered' => '',
+                'post_parent'           => 0,
+                'guid'                  => bp_rewrites_get_url(
+                    array(
+                        'component_id' => $component,
+                    )
+                ),
+                'menu_order'            => 0,
+                'post_type'             => 'buddypress',
+                'post_mime_type'        => '',
+                'comment_count'         => 0,
+                'filter'                => 'raw',
+            );
+
+            $pages[] = get_post( $post );
+        }
+
+        $pages = bp_alpha_sort_by_key( $pages, 'post_title' );
+    }
+
+    return $pages;
+}
+add_filter( 'get_pages', 'bp_core_include_directory_on_front', 10, 2 );
+
+/**
  * Filter SQL query strings to swap out the 'meta_id' column.
  *
@@ -1336 +1406 @@
 }
 add_filter( 'subdirectory_reserved_names', 'bp_core_components_subdirectory_reserved_names' );
+
+/**
+ * Make sure `buddypress` post type links are built using BP Rewrites.
+ *
+ * @since 12.0.0
+ *
+ * @param string       $link The post type link.
+ * @param WP_Post|null $post The post type object.
+ * @return string            The post type link.
+ */
+function bp_get_post_type_link( $link = '', $post = null ) {
+    if (  'rewrites' === bp_core_get_query_parser() && 'buddypress' === get_post_type( $post ) ) {
+        $bp_pages = (array) buddypress()->pages;
+
+        $bp_current_page = wp_list_filter( $bp_pages, array( 'id' => $post->ID ) );
+        if ( $bp_current_page ) {
+            $args = array(
+                'component_id' => key( $bp_current_page ),
+            );
+
+            if ( 'register' === $args['component_id'] || 'activate' === $args['component_id'] ) {
+                $key_action           = 'member_' . $args['component_id'];
+                $args['component_id'] = 'members';
+                $args[ $key_action ]  = 1;
+            }
+
+            $link = bp_rewrites_get_url( $args );
+        }
+    }
+
+    return $link;
+}
+add_filter( 'post_type_link', 'bp_get_post_type_link', 10, 2 );