Changeset 13471 for trunk/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

05/07/2023 11:36:50 AM (19 months ago)

Author:

imath

Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

• Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
• Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
• Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
• Remove the Page settings Admin help tab & move it into BP Classic
• Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (4 diffs)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -670 +670 @@
             break;
 
-        // Pages page.
-        case 'settings_page_bp-page-settings':
-            // Help tabs.
-            $screen->add_help_tab(
-                array(
-                    'id'      => 'bp-page-overview',
-                    'title'   => __( 'Overview', 'buddypress' ),
-                    'content' => bp_core_add_contextual_help_content( 'bp-page-overview' ),
-                )
-            );
-
-            // Help panel - sidebar links.
-            $screen->set_help_sidebar(
-                '<p><strong>' . __( 'For more information:', 'buddypress' ) . '</strong></p>' .
-                '<p>' . __( '<a href="https://codex.buddypress.org/getting-started/configure-components/#settings-buddypress-pages">Managing Pages</a>', 'buddypress' ) . '</p>' .
-                '<p>' . __( '<a href="https://buddypress.org/support/">Support Forums</a>', 'buddypress' ) . '</p>'
-            );
-
-            break;
-
         // Settings page.
         case 'settings_page_bp-settings':
@@ -732 +712 @@
 }
 add_action( 'load-settings_page_bp-components', 'bp_core_add_contextual_help' );
-add_action( 'load-settings_page_bp-page-settings', 'bp_core_add_contextual_help' );
 add_action( 'load-settings_page_bp-settings', 'bp_core_add_contextual_help' );
 add_action( 'load-users_page_bp-profile-setup', 'bp_core_add_contextual_help' );
@@ -749 +728 @@
         case 'bp-comp-overview':
             $retval = __( 'By default, all but four of the BuddyPress components are enabled. You can selectively enable or disable any of the components by using the form below. Your BuddyPress installation will continue to function. However, the features of the disabled components will no longer be accessible to anyone using the site.', 'buddypress' );
-            break;
-
-        case 'bp-page-overview':
-            $retval = __( 'BuddyPress Components use WordPress Pages for their root directory/archive pages. You can change the page associations for each active component by using the form below.', 'buddypress' );
             break;
 
@@ -1493 +1468 @@
  *
  * @since 8.0.0
+ * @since 12.0.0 This category is left for third party plugin but not used anymmore.
+ *
+ * @todo deprecate.
  */
 function bp_block_init_category_filter() {