Changeset 13471 for trunk/src/bp-core/admin/bp-core-admin-actions.php

Timestamp:

05/07/2023 11:36:50 AM (3 years ago)

Author:

imath

Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

• Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
• Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
• Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
• Remove the Page settings Admin help tab & move it into BP Classic
• Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-actions.php (modified) (2 diffs)

trunk/src/bp-core/admin/bp-core-admin-actions.php

@@ -61 +61 @@
 add_action( 'bp_admin_menu', 'bp_admin_separator' );
 
-// Add a filter to include BP Components directory pages display states.
-add_filter( 'display_post_states', 'bp_admin_display_directory_states', 10, 2 );
-
 /**
  * When a new site is created in a multisite installation, run the activation
@@ -239 +236 @@
     do_action( 'bp_register_admin_settings' );
 }
-
-/**
- * Dedicated filter to inform about BP components directory page states.
- *
- * @since 10.0.0
- *
- * @param string[] $post_states An array of post display states.
- * @param WP_Post  $post        The current post object.
- */
-function bp_admin_display_directory_states( $post_states = array(), $post = null ) {
-    /**
-     * Filter here to add BP Directory pages.
-     *
-     * Used internaly by BP_Component->admin_directory_states(). Please use the dynamic
-     * filter in BP_Component->admin_directory_states() to edit the directory state
-     * according to the component's ID.
-     *
-     * @since 10.0.0
-     *
-     * @param array    $value An empty array.
-     * @param WP_Post  $post  The current post object.
-     */
-    $directory_page_states = apply_filters( 'bp_admin_display_directory_states', array(), $post );
-
-    if ( $directory_page_states ) {
-        $post_states = array_merge( $post_states, $directory_page_states );
-    }
-
-    return $post_states;
-}