Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
05/07/2023 11:36:50 AM (12 months ago)
Author:
imath
Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

  • Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
  • Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
  • Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
  • Remove the Page settings Admin help tab & move it into BP Classic
  • Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-blogs/classes/class-bp-blogs-component.php

    r13464 r13471  
    528528        parent::blocks_init( $blocks );
    529529    }
    530 
    531     /**
    532      * Add the Sites directory states.
    533      *
    534      * @since 10.0.0
    535      *
    536      * @param array   $states Optional. See BP_Component::admin_directory_states() for description.
    537      * @param WP_Post $post   Optional. See BP_Component::admin_directory_states() for description.
    538      * @return array          See BP_Component::admin_directory_states() for description.
    539      */
    540     public function admin_directory_states( $states = array(), $post = null ) {
    541         $bp = buddypress();
    542 
    543         if ( isset( $bp->pages->blogs->id ) && (int) $bp->pages->blogs->id === (int) $post->ID ) {
    544             $states['page_for_sites_directory'] = _x( 'BP Sites Page', 'page label', 'buddypress' );
    545         }
    546 
    547         return parent::admin_directory_states( $states, $post );
    548     }
    549530}
Note: See TracChangeset for help on using the changeset viewer.