Changeset 13471 for trunk/src/bp-activity/classes/class-bp-activity-component.php

Timestamp:

05/07/2023 11:36:50 AM (17 months ago)

Author:

imath

Message:

BP Rewrites merge process, final touches

This commit is closing the main ticket about migrating our Legacy URL parser to using the WP Rewrite API. Please open next possible issues in new tickets.

The final touches:

• Make sure BP Activity Embeds are fully supported when using the BP Rewrites API.
• Make sure BuddyPress directories are fetched into the Site Editor's Navigation block.
• Deprecate bp_admin_display_directory_states() and move the BP Page directory states feature into the BP Classic backcompat plugin.
• Remove the Page settings Admin help tab & move it into BP Classic
• Introduce the bp_core_include_directory_on_front() in order to maintain the possibility to use a BP Directory page as the site's home page.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/95
Fixes #4954

File:

• trunk/src/bp-activity/classes/class-bp-activity-component.php (modified) (1 diff)

trunk/src/bp-activity/classes/class-bp-activity-component.php

@@ -578 +578 @@
         parent::blocks_init( $blocks );
     }
-
-    /**
-     * Add the Activity directory state.
-     *
-     * @since 10.0.0
-     *
-     * @param array   $states Optional. See BP_Component::admin_directory_states() for description.
-     * @param WP_Post $post   Optional. See BP_Component::admin_directory_states() for description.
-     * @return array          See BP_Component::admin_directory_states() for description.
-     */
-    public function admin_directory_states( $states = array(), $post = null ) {
-        $bp = buddypress();
-
-        if ( isset( $bp->pages->activity->id ) && (int) $bp->pages->activity->id === (int) $post->ID ) {
-            $states['page_for_activity_directory'] = _x( 'BP Activity Page', 'page label', 'buddypress' );
-        }
-
-        return parent::admin_directory_states( $states, $post );
-    }
 }