Changeset 13468 for trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php

Timestamp:

05/03/2023 06:18:23 AM (3 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php (modified) (1 diff)

trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php

@@ -349 +349 @@
     }
 
+    public function screen_callback() {
+        bp_core_load_template( 'members/single/plugins' );
+    }
+
+    public function new_nav_hook() {
+        bp_core_new_subnav_item(
+            array(
+                'name'            => 'Testing',
+                'slug'            => 'testing',
+                'parent_slug'     => bp_get_profile_slug(),
+                'screen_function' => array( $this, 'screen_callback' ),
+                'position'        => 20
+            )
+        );
+    }
+
     /**
      * @ticket BP7931
      */
     public function test_subnav_should_not_404_on_early_bp_setup_nav_priority() {
+        // Register a subnav on 'bp_setup_nav' hook early (at priority zero).
+        add_action( 'bp_setup_nav', array( $this, 'screen_callback' ), 0 );
+
         $u = self::factory()->user->create();
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u );
 
-        $user_domain = bp_members_get_user_url( $u );
-
-        // Register a subnav on 'bp_setup_nav' hook early (at priority zero).
-        add_action( 'bp_setup_nav', function() use ( $user_domain ) {
-            /*
-             * Emulate a subnav screen.
-             *
-             * The bp_core_load_template() call is imperative for our 404 check to work!
-             */
-            $screen = function() {
-                bp_core_load_template ('members/single/plugins');
-            };
-
-            // Register the subnav.
-            bp_core_new_subnav_item( array (
-                'name'            => 'Testing',
-                'slug'            => 'testing',
-                'parent_url'      => $user_domain . bp_get_profile_slug (). '/',
-                'parent_slug'     => bp_get_profile_slug (),
-                'screen_function' => $screen,
-                'position'        => 20
-            ) );
-        }, 0 );
+        $url = bp_members_get_user_url(
+            $u,
+            array(
+                'single_item_component' => bp_get_profile_slug(),
+                'single_item_action'    => 'testing',
+            )
+        );
 
         // Emulate visit to our new subnav page.
-        $this->go_to( $user_domain . bp_get_profile_slug () . '/testing/' );
+        $this->go_to( $url );
 
         // Assert that subnav page does not 404.
         $this->assertFalse( is_404() );
 
+        remove_action( 'bp_setup_nav', array( $this, 'screen_callback' ), 0 );
+
         $this->set_current_user( $old_current_user );
     }