Changeset 13468 for trunk/src/bp-members/classes/class-bp-members-component.php

Timestamp:

05/03/2023 06:18:23 AM (2 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-members/classes/class-bp-members-component.php (modified) (2 diffs)

trunk/src/bp-members/classes/class-bp-members-component.php

@@ -389 +389 @@
         if ( bp_displayed_user_id() ) {
             $bp->canonical_stack['base_url'] = bp_displayed_user_url();
-
-            if ( bp_current_component() ) {
-                $bp->canonical_stack['component'] = bp_current_component();
-            }
-
-            if ( bp_current_action() ) {
-                $bp->canonical_stack['action'] = bp_current_action();
-            }
-
-            if ( ! empty( $bp->action_variables ) ) {
-                $bp->canonical_stack['action_variables'] = bp_action_variables();
-            }
-
-            // Looking at the single member root/home, so assume the default.
-            if ( ! bp_current_component() ) {
+            $action_variables                = (array) bp_action_variables();
+            $path_chunks                     = bp_members_get_path_chunks(
+                array_merge(
+                    array( bp_current_component(), bp_current_action() ),
+                    array_filter( $action_variables )
+                )
+            );
+
+            if ( isset( $path_chunks['single_item_component'] ) ) {
+                $bp->canonical_stack['component'] = $path_chunks['single_item_component'];
+
+                // The canonical URL will not contain the default component.
+                if ( bp_is_current_component( $bp->default_component ) && ! bp_current_action() ) {
+                    unset( $bp->canonical_stack['component'] );
+                } elseif ( isset( $path_chunks['single_item_action'] ) ) {
+                    $bp->canonical_stack['action'] = $path_chunks['single_item_action'];
+
+                    if ( isset( $path_chunks['single_item_action_variables'] ) ) {
+                        $bp->canonical_stack['action_variables'] = $path_chunks['single_item_action_variables'];
+                    }
+                }
+
+                // Looking at the single member root/home, so assume the default.
+            } else {
                 $bp->current_component = $bp->default_component;
-
-            // The canonical URL will not contain the default component.
-            } elseif ( bp_is_current_component( $bp->default_component ) && ! bp_current_action() ) {
-                unset( $bp->canonical_stack['component'] );
-            }
-
-            // If we're on a spammer's profile page, only users with the 'bp_moderate' cap
-            // can view subpages on the spammer's profile.
-            //
-            // users without the cap trying to access a spammer's subnav page will get
-            // redirected to the root of the spammer's profile page.  this occurs by
-            // by removing the component in the canonical stack.
+            }
+
+            /*
+             * If we're on a spammer's profile page, only users with the 'bp_moderate' cap
+             * can view subpages on the spammer's profile.
+             *
+             * users without the cap trying to access a spammer's subnav page will get
+             * redirected to the root of the spammer's profile page.  this occurs by
+             * by removing the component in the canonical stack.
+             */
             if ( bp_is_user_spammer( bp_displayed_user_id() ) && ! bp_current_user_can( 'bp_moderate' ) ) {
                 unset( $bp->canonical_stack['component'] );
@@ -896 +903 @@
                 $action_variables = $query->get( $this->rewrite_ids['single_item_action_variables'] );
                 if ( $action_variables ) {
+                    $context = sprintf( 'bp_member_%1$s_%2$s_', $bp->current_component, $bp->current_action );
+
                     if ( ! is_array( $action_variables ) ) {
-                        $bp->action_variables = explode( '/', ltrim( $action_variables, '/' ) );
-                    } else {
-                        $bp->action_variables = $action_variables;
+                        $action_variables = explode( '/', ltrim( $action_variables, '/' ) );
                     }
+
+                    foreach ( $action_variables as $key_variable => $action_variable ) {
+                        $item_component_action_variable_rewrite_id = bp_rewrites_get_custom_slug_rewrite_id( 'members', $action_variable, $context );
+
+                        if ( $item_component_action_variable_rewrite_id ) {
+                            $action_variables[ $key_variable ] = str_replace( $context, '', $item_component_action_variable_rewrite_id );
+                        }
+                    }
+
+                    $bp->action_variables = $action_variables;
                 }