Changeset 13468 for trunk/src/bp-groups/classes/class-bp-groups-component.php

Timestamp:

05/03/2023 06:18:23 AM (19 months ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-groups/classes/class-bp-groups-component.php (modified) (5 diffs)

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -179 +179 @@
                 in_array( bp_current_action(), array( 'create', 'join', 'leave-group' ), true )
             ) {
-                require $this->path . 'bp-groups/actions/' . bp_current_action() . '.php';
+                require_once $this->path . 'bp-groups/actions/' . bp_current_action() . '.php';
             }
 
             // Actions - RSS feed handler.
             if ( bp_is_active( 'activity' ) && bp_is_current_action( 'feed' ) ) {
-                require $this->path . 'bp-groups/actions/feed.php';
+                require_once $this->path . 'bp-groups/actions/feed.php';
             }
 
             // Actions - Random group handler.
             if ( isset( $_GET['random-group'] ) ) {
-                require $this->path . 'bp-groups/actions/random.php';
+                require_once $this->path . 'bp-groups/actions/random.php';
             }
 
             // Screens - Directory.
             if ( bp_is_groups_directory() ) {
-                require $this->path . 'bp-groups/screens/directory.php';
+                require_once $this->path . 'bp-groups/screens/directory.php';
             }
 
             // Screens - User profile integration.
             if ( bp_is_user() ) {
-                require $this->path . 'bp-groups/screens/user/my-groups.php';
+                require_once $this->path . 'bp-groups/screens/user/my-groups.php';
 
                 if ( bp_is_current_action( 'invites' ) ) {
-                    require $this->path . 'bp-groups/screens/user/invites.php';
+                    require_once $this->path . 'bp-groups/screens/user/invites.php';
                 }
             }
@@ -209 +209 @@
             if ( bp_is_group() ) {
                 // Actions - Access protection.
-                require $this->path . 'bp-groups/actions/access.php';
+                require_once $this->path . 'bp-groups/actions/access.php';
 
                 // Public nav items.
                 if ( in_array( bp_current_action(), array( 'home', 'request-membership', 'activity', 'members', 'send-invites' ), true ) ) {
-                    require $this->path . 'bp-groups/screens/single/' . bp_current_action() . '.php';
+                    require_once $this->path . 'bp-groups/screens/single/' . bp_current_action() . '.php';
                 }
 
                 // Admin nav items.
                 if ( bp_is_item_admin() && is_user_logged_in() ) {
-                    require $this->path . 'bp-groups/screens/single/admin.php';
+                    require_once $this->path . 'bp-groups/screens/single/admin.php';
 
                     if ( in_array( bp_get_group_current_admin_tab(), array( 'edit-details', 'group-settings', 'group-avatar', 'group-cover-image', 'manage-members', 'membership-requests', 'delete-group' ), true ) ) {
-                        require $this->path . 'bp-groups/screens/single/admin/' . bp_get_group_current_admin_tab() . '.php';
+                        require_once $this->path . 'bp-groups/screens/single/admin/' . bp_get_group_current_admin_tab() . '.php';
                     }
                 }
@@ -554 +554 @@
         // Prepare for a redirect to the canonical URL.
         $bp->canonical_stack['base_url'] = bp_get_group_url( $this->current_group );
-
-        if ( bp_current_action() ) {
-            $bp->canonical_stack['action'] = bp_current_action();
-        }
+        $current_action                  = bp_current_action();
 
         /**
@@ -567 +564 @@
          */
         if ( ! $this->current_group->front_template && ( bp_is_current_action( 'activity' ) || ( ! bp_is_active( 'activity' ) && bp_is_current_action( 'members' ) ) ) ) {
-            $bp->canonical_stack['action'] = 'home';
-        }
-
-        if ( ! empty( $bp->action_variables ) ) {
-            $bp->canonical_stack['action_variables'] = bp_action_variables();
-        }
-
-        // When viewing the default extension, the canonical URL should not have
-        // that extension's slug, unless more has been tacked onto the URL via
-        // action variables.
+            $current_action = 'home';
+        }
+
+        if ( $current_action ) {
+            $context                       = 'read';
+            $path_chunks                   = bp_groups_get_path_chunks( array( $current_action ), $context );
+            $bp->canonical_stack['action'] = $current_action;
+
+            if ( isset( $path_chunks['single_item_action'] ) ) {
+                $bp->canonical_stack['action'] = $path_chunks['single_item_action'];
+            }
+
+            if ( ! empty( $bp->action_variables ) ) {
+                $key_action_variables = 'single_item_action_variables';
+
+                if ( bp_is_group_admin_page() ) {
+                    $context = 'manage';
+                } elseif ( bp_is_group_create() ) {
+                    $context              = 'create';
+                    $key_action_variables = 'create_single_item_variables';;
+                }
+
+                $path_chunks                             = bp_groups_get_path_chunks( $bp->action_variables, $context );
+                $bp->canonical_stack['action_variables'] = bp_action_variables();
+
+                if ( isset( $path_chunks[ $key_action_variables ] ) ) {
+                    $bp->canonical_stack['action_variables'] = $path_chunks[ $key_action_variables ];
+                }
+            }
+        }
+
+        /*
+         * When viewing the default extension, the canonical URL should not have
+         * that extension's slug, unless more has been tacked onto the URL via
+         * action variables.
+         */
         if ( bp_is_current_action( $this->default_extension ) && empty( $bp->action_variables ) )  {
             unset( $bp->canonical_stack['action'] );
@@ -1125 +1148 @@
                     $bp->action_variables         = array( $group_type_slug );
                 } else {
-                    $bp->current_component = false;
+                    $bp->current_component        = false;
+                    $this->current_directory_type = '';
                     bp_do_404();
                     return;