Changeset 13468 for trunk/src/bp-core/classes/class-bp-admin.php

Timestamp:

05/03/2023 06:18:23 AM (2 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-core/classes/class-bp-admin.php (modified) (2 diffs)

trunk/src/bp-core/classes/class-bp-admin.php

@@ -147 +147 @@
         require $this->admin_dir . 'bp-core-admin-functions.php';
         require $this->admin_dir . 'bp-core-admin-components.php';
-        require $this->admin_dir . 'bp-core-admin-rewrites.php';
         require $this->admin_dir . 'bp-core-admin-tools.php';
         require $this->admin_dir . 'bp-core-admin-optouts.php';
+
+        if ( 'rewrites' === bp_core_get_query_parser() ) {
+            require $this->admin_dir . 'bp-core-admin-rewrites.php';
+        }
     }
 
@@ -276 +279 @@
         $hooks[]                                          = $bp_components_page;
 
-        $bp_rewrite_settings_page = add_submenu_page(
-            $this->settings_page,
-            __( 'BuddyPress URLs', 'buddypress' ),
-            __( 'BuddyPress URLs', 'buddypress' ),
-            $this->capability,
-            'bp-rewrites',
-            'bp_core_admin_rewrites_settings'
-        );
-
-        $this->submenu_pages['settings']['bp-rewrites'] = $bp_rewrite_settings_page;
-        $hooks[]                                        = $bp_rewrite_settings_page;
+        if ( 'rewrites' === bp_core_get_query_parser() ) {
+            $bp_rewrites_settings_page = add_submenu_page(
+                $this->settings_page,
+                __( 'BuddyPress URLs', 'buddypress' ),
+                __( 'BuddyPress URLs', 'buddypress' ),
+                $this->capability,
+                'bp-rewrites',
+                'bp_core_admin_rewrites_settings'
+            );
+
+            $this->submenu_pages['settings']['bp-rewrites'] = $bp_rewrites_settings_page;
+            $hooks[]                                        = $bp_rewrites_settings_page;
+        }
 
         $bp_settings_page = add_submenu_page(