Changeset 13468 for trunk/src/bp-core/bp-core-actions.php

Timestamp:

05/03/2023 06:18:23 AM (2 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-core/bp-core-actions.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-actions.php

@@ -73 +73 @@
 add_action( 'bp_init', 'bp_register_taxonomies',     2  );
 add_action( 'bp_init', 'bp_setup_globals',           4  );
+add_action( 'bp_init', 'bp_register_nav',            5  );
 add_action( 'bp_init', 'bp_blocks_init',             10 );
 add_action( 'bp_init', 'bp_core_load_admin_bar_css', 12 );
@@ -110 +111 @@
         $key_actions['_bp_maybe_remove_redirect_canonical'] = 10;
         $key_actions['bp_remove_adjacent_posts_rel_link']   = 10;
-
-        /**
-         *
-         * @todo This code should be moved to BP Classic.
-         *
-         */
-        add_action( $hook, 'bp_core_set_uri_globals', 2 );
     }
 
@@ -127 +121 @@
 
         add_action( $hook, $action, $priority, $arguments );
+    }
+
+    // Fire a deprecation notice for following deprecated hooks, if needed.
+    if ( ! function_exists( 'bp_classic' ) ) {
+        apply_filters_deprecated( 'bp_uri', array( '' ), '12.0.0' );
+        do_action_deprecated( 'is_not_buddypress', array(), '12.0.0' );
     }
 }