Changeset 13468 for trunk/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

05/03/2023 06:18:23 AM (20 months ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (2 diffs)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -477 +477 @@
             'name' => __( 'Components', 'buddypress' ),
         ),
-        '1' => array(
-            'id'   => 'bp-rewrites',
-            'href' => bp_get_admin_url( add_query_arg( array( 'page' => 'bp-rewrites' ), 'admin.php' ) ),
-            'name' => __( 'URLs', 'buddypress' ),
-        ),
         '2' => array(
             'id'   => 'bp-settings',
@@ -493 +488 @@
         ),
     );
+
+    if ( 'rewrites' === bp_core_get_query_parser() ) {
+        $settings_tabs['1'] = array(
+            'id'   => 'bp-rewrites',
+            'href' => bp_get_admin_url( add_query_arg( array( 'page' => 'bp-rewrites' ), 'admin.php' ) ),
+            'name' => __( 'URLs', 'buddypress' ),
+        );
+    }
 
     if ( ! $apply_filters ) {