Changeset 13461 for trunk/src/bp-core/bp-core-template-loader.php

Timestamp:

04/24/2023 02:32:27 AM (2 years ago)

Author:

imath

Message:

Make canonical redirection & Ajax requesting BP Rewrites ready

• Introduces bp_core_setup_query_parser() to decide when to postpone some key hooks firing to bp_parse_query.
• Introduces bp_core_get_query_parser() to get the query parser in use. It contains a filter BP Classic will be able to use to force the Legacy URL parser. So far it uses legacy for pretty links and rewrites for plain links.
• Edit bp_redirect_canonical() & bp_get_canonical_url() so that they use the BP Rewrites API.
• Introduces bp_core_set_ajax_uri_globals() to set the BuddyPress URI globales using the BP Rewrites API inside the Ajax context thanks to the updated bp_reset_query() function.
• To avoid using WP() at each Ajax call, introduces a simple Ajax actions registration process thanks to the new bp_ajax_register_action().
• Update Legacy & Nouveau template packs so that they use this logic. As BP Default will require the legacy URL parser and will be moved inside BP Classic, the theme can stay the way it is.
• Improve the bp_rewrites_pre_get_slug filter logic making it depends on the bp_core_get_query_parser() function.
• Make sure to reset the Members navigation to a new BP_Core_Nav based on the displayed user once the user is available in the component's parse_query() method.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/91
See #4954

File:

• trunk/src/bp-core/bp-core-template-loader.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-template-loader.php

@@ -579 +579 @@
 
 /**
+ * Parse the query for the Ajax context.
+ *
+ * @since 12.0.0
+ *
+ * @param WP_Query $referer_query WP_Query object.
+ */
+function bp_parse_ajax_referer_query( $referer_query ) {
+    if ( ! wp_doing_ajax() || 'rewrites' !== bp_core_get_query_parser() ) {
+        return;
+    }
+
+    /**
+     * Fires at the end of the bp_parse_ajax_referer_query function.
+     *
+     * Allow BuddyPress components to parse the ajax referer query.
+     *
+     * @since 12.0.0
+     *
+     * @param WP_Query $posts_query WP_Query instance. Passed by reference.
+     */
+    do_action_ref_array( 'bp_parse_query', array( &$referer_query ) );
+}
+
+/**
  * Resets the query to fit our permalink structure if needed.
  *
@@ -601 +625 @@
     }
 
-    // Temporarly override the request uri.
-    if ( isset( $wp->request ) ) {
+    // Use the BP Rewrites API to parse the ajax referer request.
+    if ( wp_doing_ajax() ) {
+        if ( ! bp_has_pretty_urls() ) {
+            $matched_query = wp_parse_url( $bp_request, PHP_URL_QUERY );
+        } else {
+            // Temporarly override the request uri.
+            $_SERVER['REQUEST_URI'] = $bp_request;
+
+            $wp_ajax = new WP();
+            $wp_ajax->parse_request();
+
+            // Extra step to check for root profiles.
+            $member = bp_rewrites_get_member_data( $wp_ajax->request );
+            if ( isset( $member['object'] ) && $member['object'] ) {
+                $_SERVER['REQUEST_URI'] = trailingslashit( $bp->members->root_slug ) . $wp_ajax->request;
+
+                // Reparse the request.
+                $wp_ajax->parse_request();
+            }
+
+            $matched_query = $wp_ajax->matched_query;
+        }
+
+        // Use a specific function to fire the `bp_parse_query` hook.
+        add_action( 'parse_query', 'bp_parse_ajax_referer_query', 2 );
+
+        // Parse the matched query.
+        $query->parse_query( $matched_query );
+
+        // Use to requery in case of root profiles.
+    } elseif ( isset( $wp->request ) ) {
+        // Temporarly override the request uri.
         $_SERVER['REQUEST_URI'] = str_replace( $wp->request, $bp_request, $reset_server_request_uri );