Changeset 13461 for trunk/src/bp-core/bp-core-rewrites.php

Timestamp:

04/24/2023 02:32:27 AM (17 months ago)

Author:

imath

Message:

Make canonical redirection & Ajax requesting BP Rewrites ready

• Introduces bp_core_setup_query_parser() to decide when to postpone some key hooks firing to bp_parse_query.
• Introduces bp_core_get_query_parser() to get the query parser in use. It contains a filter BP Classic will be able to use to force the Legacy URL parser. So far it uses legacy for pretty links and rewrites for plain links.
• Edit bp_redirect_canonical() & bp_get_canonical_url() so that they use the BP Rewrites API.
• Introduces bp_core_set_ajax_uri_globals() to set the BuddyPress URI globales using the BP Rewrites API inside the Ajax context thanks to the updated bp_reset_query() function.
• To avoid using WP() at each Ajax call, introduces a simple Ajax actions registration process thanks to the new bp_ajax_register_action().
• Update Legacy & Nouveau template packs so that they use this logic. As BP Default will require the legacy URL parser and will be moved inside BP Classic, the theme can stay the way it is.
• Improve the bp_rewrites_pre_get_slug filter logic making it depends on the bp_core_get_query_parser() function.
• Make sure to reset the Members navigation to a new BP_Core_Nav based on the displayed user once the user is available in the component's parse_query() method.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/91
See #4954

File:

• trunk/src/bp-core/bp-core-rewrites.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-rewrites.php

@@ -79 +79 @@
  */
 function bp_rewrites_get_slug( $component_id = '', $rewrite_id = '', $default_slug = '' ) {
+    $using_legacy = 'legacy' === bp_core_get_query_parser();
+
     /**
-     * This filter is used by the BP Classic plugin to force `$default_slug` usage.
-     *
-     * Using the "Classic" BuddyPress means deprecated functions building URL concatening
-     * URL chunks are available, we cannot use the BP Rewrites API in this case & as a result
-     * slug customization is bypassed.
-     *
-     * The BP Classic plugin is simply returning the `$default_slug` to bypass slug customization.
+     * This filter is used to simply return the `$default_slug` to bypass slug customization
+     * when the query parser is the legacy one.
      *
      * @since 12.0.0
      *
-     * @param string $value        An empty string to use as to know whether slug customization should be used.
-     * @param string $default_slug The screen default slug, used as a fallback.
-     * @param string $rewrite_id   The screen rewrite ID, used to find the custom slugs.
-     * @param string $component_id The BuddyPress component's ID.
+     * @param boolean $using_legacy Whether the legacy URL parser is in use.
+     *                              In this case, slug customization is not supported.
+     * @param string  $default_slug The screen default slug, used as a fallback.
+     * @param string  $rewrite_id   The screen rewrite ID, used to find the custom slugs.
+     * @param string  $component_id The BuddyPress component's ID.
      */
-    $classic_slug = apply_filters( 'bp_rewrites_pre_get_slug', '', $default_slug, $rewrite_id, $component_id );
-    if ( $classic_slug ) {
-        return $classic_slug;
+    $use_default_slug = apply_filters( 'bp_rewrites_pre_get_slug', $using_legacy, $default_slug, $rewrite_id, $component_id );
+    if ( $use_default_slug ) {
+        return $default_slug;
     }
 
@@ -211 +209 @@
             }
 
-            $url = add_query_arg( $qv, $url );
+            $url = add_query_arg( $qv, trailingslashit( $url ) );
 
             // Using pretty URLs.