Changeset 13457

Timestamp:

04/22/2023 07:35:59 AM (3 years ago)

Author:

imath

Message:

BP Nouveau's message UI: make sure the reply action gets needed data

Adding a reply can be done by opening the thread view from the message UI or by directly accessing to this view from its URL.
In both cases, we need to make sure to get the current Thread ID in order to attach the reply to it.
As the Backbone Model or the fallback object are both including an id property, using it is a better choice than trying to access the Backbone Model's id attribute.

Props dave.pullig

Closes ​https://github.com/buddypress/buddypress/pull/89
See #8870 (trunk)

File:

• trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js (modified) (3 diffs)

trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js

@@ -2 +2 @@
 /* jshint devel: true */
 /* @since 3.0.0 */
-/* @version 10.3.0 */
+/* @version 11.2.0 */
 window.wp = window.wp || {};
 window.bp = window.bp || {};
@@ -1355 +1355 @@
 
                 messagesFetched: function( collection, response ) {
-                        if ( response.thread && !! response.thread.length ) {
+                        if ( response.thread && !! response.thread.id ) {
                                 this.options.thread = new Backbone.Model( response.thread );
                         }
@@ -1388 +1388 @@
 
                         threadItem = this.options.thread;
-                        if ( ! threadItem.has( 'id' ) ) {
+                        if ( ! threadItem.id ) {
                                 threadItem = this.options.collection.at( 0 );
                         }
 
                         this.reply.set ( {
-                                thread_id : threadItem.get( 'id' ),
+                                thread_id : threadItem.id,
                                 content   : tinyMCE.activeEditor.getContent(),
                                 sending   : true