Changeset 13455 for trunk/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

04/20/2023 02:30:11 AM (2 years ago)

Author:

imath

Message:

Start implementing parse_query() methods for directory components

First concerned commponents are: Activity, Blogs & Members.

• Remove the notice used to force pretty permalinks
• Use plain links to test parse_query() methods are rightly setting BuddyPress URI globals
• Introduce some helper functions used during the BP Rewrites API parsing process :
  • bp_is_directory_homepage() is checking if a BP Directory is used as the site's homepage
  • bp_rewrites_get_custom_slug_rewrite_id() finds a Rewrite ID out of a custom slug.
  • bp_rewrites_get_member_data() returns the field to use to get the user by.
  • bp_reset_query() makes it possible to parse again a request in specific cases (eg: root profiles)

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/87
See #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (2 diffs)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -205 +205 @@
  *
  * On every Dashboard page, this function checks the following:
- *   - that pretty permalinks are enabled.
  *   - that every BP component that needs a WP page for a directory has one.
  *   - that no WP page has multiple BP components associated with it.
@@ -250 +249 @@
             bp_blogs_record_existing_blogs();
         }
-    }
-
-    // Add notice if no rewrite rules are enabled.
-    if ( empty( $wp_rewrite->permalink_structure ) ) {
-        bp_core_add_admin_notice(
-            sprintf(
-                // Translators: %s is the url to the permalink settings.
-                __( '<strong>BuddyPress is almost ready</strong>. You must <a href="%s">update your permalink structure</a> to something other than the default for it to work.', 'buddypress' ),
-                admin_url( 'options-permalink.php' )
-            ),
-            'error'
-        );
     }