Changeset 13449 for trunk/tests/phpunit/testcases/routing/groups.php

Timestamp:

04/08/2023 06:31:46 AM (2 years ago)

Author:

imath

Message:

Make sure all Groups component URLs are built using BP rewrites API

• Introduce the bp_groups_get_create_url() to ease Groups create URLs generation.
• Improve bp_groups_get_path_chunks() to deal with front-end group admin URLs and the Groups create URLs.
• Deprecate bp_get_groups_directory_permalink() in favor of bp_get_groups_directory_url().
• Replace all remaining deprecated functions usage.
• Start putting deprecated functions behind a function_exists( 'bp_classic' ) check, corresponding functions were added inside the BP Classic backcompat plugin.
• Adjust some Groups routing unit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/83
See #4954

File:

• trunk/tests/phpunit/testcases/routing/groups.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/routing/groups.php

@@ -56 +56 @@
         $this->set_permalink_structure( '/%postname%/' );
         bp_groups_register_group_type( 'foo' );
-        $this->go_to( bp_get_groups_directory_permalink() . 'type/foo/' );
+        $this->go_to(
+            bp_get_groups_directory_url(
+                array(
+                    'directory_type' => 'foo',
+                )
+            )
+        );
         $this->assertTrue( bp_is_groups_component() && ! bp_is_group() && bp_is_current_action( bp_get_groups_group_type_base() ) && bp_is_action_variable( 'foo', 0 ) );
     }
@@ -66 +72 @@
         $this->set_permalink_structure( '/%postname%/' );
         bp_groups_register_group_type( 'foo', array( 'has_directory' => 'foos' ) );
-        $this->go_to( bp_get_groups_directory_permalink() . 'type/foos/' );
+        $this->go_to(
+            bp_get_groups_directory_url(
+                array(
+                    'directory_type' => 'foos',
+                )
+            )
+        );
         $this->assertTrue( bp_is_groups_component() && ! bp_is_group() && bp_is_current_action( bp_get_groups_group_type_base() ) && bp_is_action_variable( 'foos', 0 ) );
     }
@@ -76 +88 @@
         $this->set_permalink_structure( '/%postname%/' );
         bp_groups_register_group_type( 'taz', array( 'has_directory' => false ) );
-        $this->go_to( bp_get_groups_directory_permalink() . 'type/taz/' );
+        $this->go_to(
+            bp_get_groups_directory_url(
+                array(
+                    'directory_type' => 'taz',
+                )
+            )
+        );
         $this->assertEmpty( bp_get_current_group_directory_type() );
     }
@@ -85 +103 @@
     public function test_group_directory_should_404_for_invalid_group_types() {
         $this->set_permalink_structure( '/%postname%/' );
-        $this->go_to( bp_get_groups_directory_permalink() . 'type/zat/' );
+        $this->go_to(
+            bp_get_groups_directory_url(
+                array(
+                    'directory_type' => 'zat',
+                )
+            )
+        );
         $this->assertEmpty( bp_get_current_group_directory_type() );
     }
@@ -94 +118 @@
     public function test_group_previous_slug_current_slug_should_resolve() {
         $this->set_permalink_structure( '/%postname%/' );
-        $g1 = self::factory()->group->create( array(
-            'slug' => 'george',
-        ) );
-        groups_edit_base_group_details( array(
-            'group_id' => $g1,
-            'slug'     => 'ralph',
-        ) );
-
-        $this->go_to( bp_get_groups_directory_permalink() . 'ralph' );
-
+        $g1 = self::factory()->group->create(
+            array(
+                'slug' => 'george',
+            )
+        );
+
+        groups_edit_base_group_details(
+            array(
+                'group_id' => $g1,
+                'slug'     => 'ralph',
+            )
+        );
+
+        $this->go_to( bp_get_group_url( $g1 ) );
+        $this->assertEquals( groups_get_current_group()->slug, 'ralph' );
+    }
+
+    /**
+     * @group group_previous_slug
+     */
+    public function test_group_previous_slug_should_resolve() {
+        $this->set_permalink_structure( '/%postname%/' );
+        $g1 = self::factory()->group->create(
+            array(
+                'slug' => 'george',
+            )
+        );
+
+        groups_edit_base_group_details(
+            array(
+                'group_id'       => $g1,
+                'slug'           => 'sam!',
+                'notify_members' => false,
+            )
+        );
+
+        $url = bp_rewrites_get_url(
+            array(
+                'component_id' => 'groups',
+                'single_item'  => 'george',
+            )
+        );
+
+        $this->go_to( $url );
         $this->assertEquals( $g1, bp_get_current_group_id() );
     }
@@ -109 +167 @@
     /**
      * @group group_previous_slug
-     */
-    public function test_group_previous_slug_should_resolve() {
-        $this->set_permalink_structure( '/%postname%/' );
-        $g1 = self::factory()->group->create( array(
-            'slug' => 'george',
-        ) );
-
-        groups_edit_base_group_details( array(
-            'group_id'       => $g1,
-            'slug'           => 'sam!',
-            'notify_members' => false,
-        ) );
-        $this->go_to( bp_get_groups_directory_permalink() . 'george' );
-
-        $this->assertEquals( $g1, bp_get_current_group_id() );
-    }
-
-    /**
-     * @group group_previous_slug
+     * @group imath
      */
     public function test_group_previous_slug_most_recent_takes_precedence() {
         $this->set_permalink_structure( '/%postname%/' );
-        $g1 = self::factory()->group->create( array(
-            'slug' => 'george',
-        ) );
-        groups_edit_base_group_details( array(
-            'group_id'       => $g1,
-            'slug'           => 'ralph',
-            'notify_members' => false,
-        ) );
-        $g2 = self::factory()->group->create( array(
-            'slug' => 'george',
-        ) );
-        groups_edit_base_group_details( array(
-            'group_id'       => $g2,
-            'slug'           => 'sam',
-            'notify_members' => false,
-        ) );
-
-        $this->go_to( bp_get_groups_directory_permalink() . 'george' );
+        $g1 = self::factory()->group->create(
+            array(
+                'slug' => 'george',
+            )
+        );
+
+        groups_edit_base_group_details(
+            array(
+                'group_id'       => $g1,
+                'slug'           => 'ralph',
+                'notify_members' => false,
+            )
+        );
+
+        $g2 = self::factory()->group->create(
+            array(
+                'slug' => 'george',
+            )
+        );
+
+        groups_edit_base_group_details(
+            array(
+                'group_id'       => $g2,
+                'slug'           => 'sam',
+                'notify_members' => false,
+            )
+        );
+
+        $url = bp_rewrites_get_url(
+            array(
+                'component_id' => 'groups',
+                'single_item'  => 'george',
+            )
+        );
+
+        $this->go_to( $url );
         $this->assertEquals( $g2, bp_get_current_group_id() );
     }