Changeset 13449 for trunk/src/bp-groups/bp-groups-admin.php

Timestamp:

04/08/2023 06:31:46 AM (3 years ago)

Author:

imath

Message:

Make sure all Groups component URLs are built using BP rewrites API

• Introduce the bp_groups_get_create_url() to ease Groups create URLs generation.
• Improve bp_groups_get_path_chunks() to deal with front-end group admin URLs and the Groups create URLs.
• Deprecate bp_get_groups_directory_permalink() in favor of bp_get_groups_directory_url().
• Replace all remaining deprecated functions usage.
• Start putting deprecated functions behind a function_exists( 'bp_classic' ) check, corresponding functions were added inside the BP Classic backcompat plugin.
• Adjust some Groups routing unit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/83
See #4954

File:

• trunk/src/bp-groups/bp-groups-admin.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-admin.php

@@ -637 +637 @@
 
         // Construct URL for form.
-        $form_url = remove_query_arg( array( 'action', 'deleted', 'no_admins', 'error', 'error_new', 'success_new', 'error_modified', 'success_modified' ), $_SERVER['REQUEST_URI'] );
-        $form_url = add_query_arg( 'action', 'save', $form_url );
-        $create_url = bp_get_groups_directory_url(
-                array(
-                        'create_single_item' => 1,
-                )
-        );
+        $form_url   = remove_query_arg( array( 'action', 'deleted', 'no_admins', 'error', 'error_new', 'success_new', 'error_modified', 'success_modified' ), $_SERVER['REQUEST_URI'] );
+        $form_url   = add_query_arg( 'action', 'save', $form_url );
+        $create_url = bp_groups_get_create_url();
 
         /**
@@ -819 +815 @@
         // Prepare the group items for display.
         $bp_groups_list_table->prepare_items();
-        $create_url = bp_get_groups_directory_url(
-                array(
-                        'create_single_item' => 1,
-                )
-        );
+        $create_url = bp_groups_get_create_url();
 
         /**