Changeset 13448 for trunk/tests/phpunit/testcases/routing/groups.php

Timestamp:

04/07/2023 07:47:34 AM (2 years ago)

Author:

imath

Message:

Do 404 when trying to reach a page about an unregistered group type

Improves the way we handle this case making sure we really end up to a
404 if the corresponding group type is not registered or do not support
directory filtering. Update corresponding PHP unit tests to really test
this case instead of a case about a member type.

Closes ​https://github.com/buddypress/buddypress/pull/82
Fixes #8866

File:

• trunk/tests/phpunit/testcases/routing/groups.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/routing/groups.php

@@ -75 +75 @@
     public function test_group_directory_should_404_for_group_types_that_have_no_directory() {
         $this->set_permalink_structure( '/%postname%/' );
-        bp_register_member_type( 'foo', array( 'has_directory' => false ) );
-        $this->go_to( bp_get_members_directory_permalink() . 'type/foo/' );
-        $this->assertTrue( is_404() );
+        bp_groups_register_group_type( 'taz', array( 'has_directory' => false ) );
+        $this->go_to( bp_get_groups_directory_permalink() . 'type/taz/' );
+        $this->assertEmpty( bp_get_current_group_directory_type() );
     }
 
@@ -85 +85 @@
     public function test_group_directory_should_404_for_invalid_group_types() {
         $this->set_permalink_structure( '/%postname%/' );
-        $this->go_to( bp_get_members_directory_permalink() . 'type/foo/' );
-        $this->assertTrue( is_404() );
+        $this->go_to( bp_get_groups_directory_permalink() . 'type/zat/' );
+        $this->assertEmpty( bp_get_current_group_directory_type() );
     }