Changeset 13446 for trunk/src/bp-templates/bp-legacy/buddypress-functions.php

Timestamp:

04/04/2023 01:06:03 AM (2 years ago)

Author:

imath

Message:

Use the BP Rewrites API to generate single Groups item links

• Introduce the bp_groups_get_path_chunks() function to build BP Rewrites arguments using a regular array.
• Improve bp_members_get_path_chunks() so that it avoids looking for a custom slug when the chunk is a numeric value.
• Introduce the bp_get_group_manage_url() function to build Group's front-end Admin URLs using BP Rewrites.
• Deprecate bp_group_admin_permalink() & bp_get_group_admin_permalink() in favor of bp_group_manage_url() & bp_get_group_manage_url().
• Replace all remaining usage of bp_get_group_permalink() in favor of bp_get_group_url() or bp_get_group_manage_url().

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/81
See #4954

File:

• trunk/src/bp-templates/bp-legacy/buddypress-functions.php (modified) (4 diffs)

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1423 +1423 @@
         $user = new BP_Core_User( $friend_id );
 
-        $uninvite_url = bp_is_current_action( 'create' )
-            ? bp_get_groups_directory_permalink() . 'create/step/group-invites/?user_id=' . $friend_id
-            : bp_get_group_permalink( $group )    . 'send-invites/remove/' . $friend_id;
+        if ( bp_is_current_action( 'create' ) ) {
+            $uninvite_url = bp_get_groups_directory_permalink() . 'create/step/group-invites/?user_id=' . $friend_id;
+        } else {
+            $path_chunks  = bp_groups_get_path_chunks( array( 'send-invites', 'remove', $friend_id ) );
+            $uninvite_url = bp_get_group_url( $group, $path_chunks );
+        }
 
         echo '<li id="uid-' . esc_attr( $user->id ) . '">';
@@ -1641 +1644 @@
                 _e( 'Error joining group', 'buddypress' );
             } else {
-                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
+                $leave_url = wp_nonce_url(
+                    bp_get_group_url(
+                        $group,
+                        bp_groups_get_path_chunks( array( 'leave-group' ) )
+                    ),
+                    'groups_leave_group'
+                );
+                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . esc_url( $leave_url ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
             }
         break;
@@ -1655 +1665 @@
                 _e( 'Error requesting membership', 'buddypress' );
             } else {
-                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
+                $leave_url = wp_nonce_url(
+                    bp_get_group_url(
+                        $group,
+                        bp_groups_get_path_chunks( array( 'leave-group' ) )
+                    ),
+                    'groups_leave_group'
+                );
+                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . esc_url( $leave_url ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
             }
         break;
@@ -1675 +1692 @@
                 _e( 'Error leaving group', 'buddypress' );
             } elseif ( 'public' === $group->status ) {
-                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button join-group" rel="join" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'join', 'groups_join_group' ) . '">' . __( 'Join Group', 'buddypress' ) . '</a>';
+                $join_url = wp_nonce_url(
+                    bp_get_group_url(
+                        $group,
+                        bp_groups_get_path_chunks( array( 'join' ) )
+                    ),
+                    'groups_join_group'
+                );
+                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button join-group" rel="join" href="' . esc_url( $join_url ) . '">' . __( 'Join Group', 'buddypress' ) . '</a>';
             } else {
-                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button request-membership" rel="join" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'request-membership', 'groups_request_membership' ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
+                $request_url = wp_nonce_url(
+                    bp_get_group_url(
+                        $group,
+                        bp_groups_get_path_chunks( array( 'request-membership' ) )
+                    ),
+                    'groups_request_membership'
+                );
+                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button request-membership" rel="join" href="' . esc_url( $request_url ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
             }
         break;